Page MenuHomePhabricator
Differential D11711

[identity] Add verification for replacing a device
ClosedPublic
Actions

Authored by bartek on Apr 22 2024, 6:46 AM.
Tags
None
Referenced Files
F2021425: D11711.id39611.diff
Sun, Jun 16, 7:56 PM
Unknown Object (File)
Thu, Jun 13, 7:19 PM
Unknown Object (File)
Tue, Jun 11, 7:34 PM
Unknown Object (File)
Mon, Jun 10, 10:38 AM
Unknown Object (File)
Mon, Jun 10, 10:38 AM
Unknown Object (File)
Mon, Jun 10, 9:37 AM
Unknown Object (File)
Thu, Jun 6, 10:54 PM
Unknown Object (File)
Sat, May 18, 1:02 PM
View All 15 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
Commits
rCOMMca4595d363c0: [identity] Add verification for replacing a device
Summary

Added possibility to replace a device in device list

Depends on D11687

Test Plan
  • Added unit tests
  • Called UpdateDeviceList RPC with payload that replaced exactly one device - pass
  • Called UpdateDeviceList RPC with payload that tried to replace primary device - fail

Diff Detail

Repository
rCOMM Comm
Branch
barthap/device-list-update
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Apr 22 2024, 6:46 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 22 2024, 6:46 AM
Harbormaster completed remote builds in B28354: Diff 39343.Apr 22 2024, 7:05 AM
bartek published this revision for review.Apr 23 2024, 11:59 PM
varun accepted this revision.Apr 25 2024, 10:09 PM
varun added inline comments.
services/identity/src/device_list.rs
106
127

don't we need to make sure that the previous and new device in the replacement are both keyservers?

This revision is now accepted and ready to land.Apr 25 2024, 10:09 PM
bartek added inline comments.Apr 28 2024, 11:10 PM
services/identity/src/device_list.rs
127

Yeah this comment is a bit misleading. These validation functions are device-type-agnostic. Generally the logic is going to be extended when we add support for keyserver QR login

Closed by commit rCOMMca4595d363c0: [identity] Add verification for replacing a device (authored by bartek). · Explain WhyApr 28 2024, 11:17 PM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMca4595d363c0: [identity] Add verification for replacing a device.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
52 lines

Diff 39343

View Options

services/identity/src/device_list.rs

Loading...