Page MenuHomePhabricator
Differential D12433

[identity] continue converting/deduping tonic status messages
ClosedPublic
Actions

Authored by varun on Jun 13 2024, 1:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 13, 10:27 AM
Unknown Object (File)
Tue, Mar 4, 1:29 AM
Unknown Object (File)
Feb 28 2025, 2:26 PM
Unknown Object (File)
Feb 28 2025, 2:25 PM
Unknown Object (File)
Feb 6 2025, 9:07 AM
Unknown Object (File)
Feb 3 2025, 11:13 AM
Unknown Object (File)
Jan 30 2025, 2:54 PM
Unknown Object (File)
Jan 30 2025, 2:54 PM
View All 53 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
Commits
rCOMMaa9d2de90cc1: [identity] continue converting/deduping tonic status messages
Summary

Depends on D12432

there are a lot of tonic status messages that need to be converted to snake_case and dedup'd.

i've arbitrarily broken this work up into chunks to make it easier to review

Test Plan

git grep for the old status messages, change client error handling where needed

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
services/
identity/
src/
16 lines
9 lines
8 lines
grpc_services/
24 lines

Diff 41407

View Options

services/identity/src/client_service.rs

Show First 20 Lines • Show All 456 Lines • ▼ Show 20 Lines ) {
const lateResponsesSet = new Set<number>( const lateResponsesSet = new Set<number>(
state.keyserverInfos[keyserverID].connection.lateResponses, state.keyserverInfos[keyserverID].connection.lateResponses,
); );
if (isLate) { if (isLate) {
lateResponsesSet.add(messageID); lateResponsesSet.add(messageID);
} else { } else {
lateResponsesSet.delete(messageID); lateResponsesSet.delete(messageID);
} }
return { const operation: ReplaceKeyserverOperation = {
...state, type: 'replace_keyserver',
keyserverInfos: { payload: {
...state.keyserverInfos, id: keyserverID,
[keyserverID]: { keyserverInfo: {
...state.keyserverInfos[keyserverID], ...state.keyserverInfos[keyserverID],
connection: { connection: {
...state.keyserverInfos[keyserverID].connection, ...state.keyserverInfos[keyserverID].connection,
lateResponses: [...lateResponsesSet], lateResponses: [...lateResponsesSet],
}, },
}, },
}, },
}; };
} else if (action.type === updateDisconnectedBarActionType) {
const { keyserverID } = action.payload;
return { return {
...state, ...state,
keyserverInfos: { keyserverInfos: processStoreOps(state.keyserverInfos, [operation]),
...state.keyserverInfos, };
[keyserverID]: { } else if (action.type === updateDisconnectedBarActionType) {
const { keyserverID } = action.payload;
const operation: ReplaceKeyserverOperation = {
type: 'replace_keyserver',
payload: {
id: keyserverID,
keyserverInfo: {
...state.keyserverInfos[keyserverID], ...state.keyserverInfos[keyserverID],
connection: { connection: {
...state.keyserverInfos[keyserverID].connection, ...state.keyserverInfos[keyserverID].connection,
showDisconnectedBar: action.payload.visible, showDisconnectedBar: action.payload.visible,
}, },
}, },
}, },
}; };
return {
...state,
keyserverInfos: processStoreOps(state.keyserverInfos, [operation]),
};
} else if (action.type === setDeviceTokenActionTypes.success) { } else if (action.type === setDeviceTokenActionTypes.success) {
const { deviceTokens } = action.payload; const { deviceTokens } = action.payload;
const keyserverInfos: { ...KeyserverInfos } = { ...state.keyserverInfos }; const keyserverInfos: { ...KeyserverInfos } = { ...state.keyserverInfos };
for (const keyserverID in deviceTokens) { for (const keyserverID in deviceTokens) {
keyserverInfos[keyserverID] = { keyserverInfos[keyserverID] = {
...keyserverInfos[keyserverID], ...keyserverInfos[keyserverID],
deviceToken: deviceTokens[keyserverID], deviceToken: deviceTokens[keyserverID],
}; };
} }
return { return {
...state, ...state,
keyserverInfos, keyserverInfos,
}; };
} else if (action.type === setConnectionIssueActionType) { } else if (action.type === setConnectionIssueActionType) {
const { connectionIssue, keyserverID } = action.payload; const { connectionIssue, keyserverID } = action.payload;
return { const operation: ReplaceKeyserverOperation = {
...state, type: 'replace_keyserver',
keyserverInfos: { payload: {
...state.keyserverInfos, id: keyserverID,
[keyserverID]: { keyserverInfo: {
...state.keyserverInfos[keyserverID], ...state.keyserverInfos[keyserverID],
connection: { connection: {
...state.keyserverInfos[keyserverID].connection, ...state.keyserverInfos[keyserverID].connection,
connectionIssue, connectionIssue,
}, },
}, },
}, },
}; };
return {
...state,
keyserverInfos: processStoreOps(state.keyserverInfos, [operation]),
};
} }
return state; return state;
} }
View Options

services/identity/src/constants.rs

Show First 20 Lines • Show All 456 Lines • ▼ Show 20 Lines ) {
const lateResponsesSet = new Set<number>( const lateResponsesSet = new Set<number>(
state.keyserverInfos[keyserverID].connection.lateResponses, state.keyserverInfos[keyserverID].connection.lateResponses,
); );
if (isLate) { if (isLate) {
lateResponsesSet.add(messageID); lateResponsesSet.add(messageID);
} else { } else {
lateResponsesSet.delete(messageID); lateResponsesSet.delete(messageID);
} }
return { const operation: ReplaceKeyserverOperation = {
...state, type: 'replace_keyserver',
keyserverInfos: { payload: {
...state.keyserverInfos, id: keyserverID,
[keyserverID]: { keyserverInfo: {
...state.keyserverInfos[keyserverID], ...state.keyserverInfos[keyserverID],
connection: { connection: {
...state.keyserverInfos[keyserverID].connection, ...state.keyserverInfos[keyserverID].connection,
lateResponses: [...lateResponsesSet], lateResponses: [...lateResponsesSet],
}, },
}, },
}, },
}; };
} else if (action.type === updateDisconnectedBarActionType) {
const { keyserverID } = action.payload;
return { return {
...state, ...state,
keyserverInfos: { keyserverInfos: processStoreOps(state.keyserverInfos, [operation]),
...state.keyserverInfos, };
[keyserverID]: { } else if (action.type === updateDisconnectedBarActionType) {
const { keyserverID } = action.payload;
const operation: ReplaceKeyserverOperation = {
type: 'replace_keyserver',
payload: {
id: keyserverID,
keyserverInfo: {
...state.keyserverInfos[keyserverID], ...state.keyserverInfos[keyserverID],
connection: { connection: {
...state.keyserverInfos[keyserverID].connection, ...state.keyserverInfos[keyserverID].connection,
showDisconnectedBar: action.payload.visible, showDisconnectedBar: action.payload.visible,
}, },
}, },
}, },
}; };
return {
...state,
keyserverInfos: processStoreOps(state.keyserverInfos, [operation]),
};
} else if (action.type === setDeviceTokenActionTypes.success) { } else if (action.type === setDeviceTokenActionTypes.success) {
const { deviceTokens } = action.payload; const { deviceTokens } = action.payload;
const keyserverInfos: { ...KeyserverInfos } = { ...state.keyserverInfos }; const keyserverInfos: { ...KeyserverInfos } = { ...state.keyserverInfos };
for (const keyserverID in deviceTokens) { for (const keyserverID in deviceTokens) {
keyserverInfos[keyserverID] = { keyserverInfos[keyserverID] = {
...keyserverInfos[keyserverID], ...keyserverInfos[keyserverID],
deviceToken: deviceTokens[keyserverID], deviceToken: deviceTokens[keyserverID],
}; };
} }
return { return {
...state, ...state,
keyserverInfos, keyserverInfos,
}; };
} else if (action.type === setConnectionIssueActionType) { } else if (action.type === setConnectionIssueActionType) {
const { connectionIssue, keyserverID } = action.payload; const { connectionIssue, keyserverID } = action.payload;
return { const operation: ReplaceKeyserverOperation = {
...state, type: 'replace_keyserver',
keyserverInfos: { payload: {
...state.keyserverInfos, id: keyserverID,
[keyserverID]: { keyserverInfo: {
...state.keyserverInfos[keyserverID], ...state.keyserverInfos[keyserverID],
connection: { connection: {
...state.keyserverInfos[keyserverID].connection, ...state.keyserverInfos[keyserverID].connection,
connectionIssue, connectionIssue,
}, },
}, },
}, },
}; };
return {
...state,
keyserverInfos: processStoreOps(state.keyserverInfos, [operation]),
};
} }
return state; return state;
} }
View Options

services/identity/src/device_list.rs

Show First 20 Lines • Show All 456 Lines • ▼ Show 20 Lines ) {
const lateResponsesSet = new Set<number>( const lateResponsesSet = new Set<number>(
state.keyserverInfos[keyserverID].connection.lateResponses, state.keyserverInfos[keyserverID].connection.lateResponses,
); );
if (isLate) { if (isLate) {
lateResponsesSet.add(messageID); lateResponsesSet.add(messageID);
} else { } else {
lateResponsesSet.delete(messageID); lateResponsesSet.delete(messageID);
} }
return { const operation: ReplaceKeyserverOperation = {
...state, type: 'replace_keyserver',
keyserverInfos: { payload: {
...state.keyserverInfos, id: keyserverID,
[keyserverID]: { keyserverInfo: {
...state.keyserverInfos[keyserverID], ...state.keyserverInfos[keyserverID],
connection: { connection: {
...state.keyserverInfos[keyserverID].connection, ...state.keyserverInfos[keyserverID].connection,
lateResponses: [...lateResponsesSet], lateResponses: [...lateResponsesSet],
}, },
}, },
}, },
}; };
} else if (action.type === updateDisconnectedBarActionType) {
const { keyserverID } = action.payload;
return { return {
...state, ...state,
keyserverInfos: { keyserverInfos: processStoreOps(state.keyserverInfos, [operation]),
...state.keyserverInfos, };
[keyserverID]: { } else if (action.type === updateDisconnectedBarActionType) {
const { keyserverID } = action.payload;
const operation: ReplaceKeyserverOperation = {
type: 'replace_keyserver',
payload: {
id: keyserverID,
keyserverInfo: {
...state.keyserverInfos[keyserverID], ...state.keyserverInfos[keyserverID],
connection: { connection: {
...state.keyserverInfos[keyserverID].connection, ...state.keyserverInfos[keyserverID].connection,
showDisconnectedBar: action.payload.visible, showDisconnectedBar: action.payload.visible,
}, },
}, },
}, },
}; };
return {
...state,
keyserverInfos: processStoreOps(state.keyserverInfos, [operation]),
};
} else if (action.type === setDeviceTokenActionTypes.success) { } else if (action.type === setDeviceTokenActionTypes.success) {
const { deviceTokens } = action.payload; const { deviceTokens } = action.payload;
const keyserverInfos: { ...KeyserverInfos } = { ...state.keyserverInfos }; const keyserverInfos: { ...KeyserverInfos } = { ...state.keyserverInfos };
for (const keyserverID in deviceTokens) { for (const keyserverID in deviceTokens) {
keyserverInfos[keyserverID] = { keyserverInfos[keyserverID] = {
...keyserverInfos[keyserverID], ...keyserverInfos[keyserverID],
deviceToken: deviceTokens[keyserverID], deviceToken: deviceTokens[keyserverID],
}; };
} }
return { return {
...state, ...state,
keyserverInfos, keyserverInfos,
}; };
} else if (action.type === setConnectionIssueActionType) { } else if (action.type === setConnectionIssueActionType) {
const { connectionIssue, keyserverID } = action.payload; const { connectionIssue, keyserverID } = action.payload;
return { const operation: ReplaceKeyserverOperation = {
...state, type: 'replace_keyserver',
keyserverInfos: { payload: {
...state.keyserverInfos, id: keyserverID,
[keyserverID]: { keyserverInfo: {
...state.keyserverInfos[keyserverID], ...state.keyserverInfos[keyserverID],
connection: { connection: {
...state.keyserverInfos[keyserverID].connection, ...state.keyserverInfos[keyserverID].connection,
connectionIssue, connectionIssue,
}, },
}, },
}, },
}; };
return {
...state,
keyserverInfos: processStoreOps(state.keyserverInfos, [operation]),
};
} }
return state; return state;
} }
View Options

services/identity/src/grpc_services/authenticated.rs

Show First 20 Lines • Show All 456 Lines • ▼ Show 20 Lines ) {
const lateResponsesSet = new Set<number>( const lateResponsesSet = new Set<number>(
state.keyserverInfos[keyserverID].connection.lateResponses, state.keyserverInfos[keyserverID].connection.lateResponses,
); );
if (isLate) { if (isLate) {
lateResponsesSet.add(messageID); lateResponsesSet.add(messageID);
} else { } else {
lateResponsesSet.delete(messageID); lateResponsesSet.delete(messageID);
} }
return { const operation: ReplaceKeyserverOperation = {
...state, type: 'replace_keyserver',
keyserverInfos: { payload: {
...state.keyserverInfos, id: keyserverID,
[keyserverID]: { keyserverInfo: {
...state.keyserverInfos[keyserverID], ...state.keyserverInfos[keyserverID],
connection: { connection: {
...state.keyserverInfos[keyserverID].connection, ...state.keyserverInfos[keyserverID].connection,
lateResponses: [...lateResponsesSet], lateResponses: [...lateResponsesSet],
}, },
}, },
}, },
}; };
} else if (action.type === updateDisconnectedBarActionType) {
const { keyserverID } = action.payload;
return { return {
...state, ...state,
keyserverInfos: { keyserverInfos: processStoreOps(state.keyserverInfos, [operation]),
...state.keyserverInfos, };
[keyserverID]: { } else if (action.type === updateDisconnectedBarActionType) {
const { keyserverID } = action.payload;
const operation: ReplaceKeyserverOperation = {
type: 'replace_keyserver',
payload: {
id: keyserverID,
keyserverInfo: {
...state.keyserverInfos[keyserverID], ...state.keyserverInfos[keyserverID],
connection: { connection: {
...state.keyserverInfos[keyserverID].connection, ...state.keyserverInfos[keyserverID].connection,
showDisconnectedBar: action.payload.visible, showDisconnectedBar: action.payload.visible,
}, },
}, },
}, },
}; };
return {
...state,
keyserverInfos: processStoreOps(state.keyserverInfos, [operation]),
};
} else if (action.type === setDeviceTokenActionTypes.success) { } else if (action.type === setDeviceTokenActionTypes.success) {
const { deviceTokens } = action.payload; const { deviceTokens } = action.payload;
const keyserverInfos: { ...KeyserverInfos } = { ...state.keyserverInfos }; const keyserverInfos: { ...KeyserverInfos } = { ...state.keyserverInfos };
for (const keyserverID in deviceTokens) { for (const keyserverID in deviceTokens) {
keyserverInfos[keyserverID] = { keyserverInfos[keyserverID] = {
...keyserverInfos[keyserverID], ...keyserverInfos[keyserverID],
deviceToken: deviceTokens[keyserverID], deviceToken: deviceTokens[keyserverID],
}; };
} }
return { return {
...state, ...state,
keyserverInfos, keyserverInfos,
}; };
} else if (action.type === setConnectionIssueActionType) { } else if (action.type === setConnectionIssueActionType) {
const { connectionIssue, keyserverID } = action.payload; const { connectionIssue, keyserverID } = action.payload;
return { const operation: ReplaceKeyserverOperation = {
...state, type: 'replace_keyserver',
keyserverInfos: { payload: {
...state.keyserverInfos, id: keyserverID,
[keyserverID]: { keyserverInfo: {
...state.keyserverInfos[keyserverID], ...state.keyserverInfos[keyserverID],
connection: { connection: {
...state.keyserverInfos[keyserverID].connection, ...state.keyserverInfos[keyserverID].connection,
connectionIssue, connectionIssue,
}, },
}, },
}, },
}; };
return {
...state,
keyserverInfos: processStoreOps(state.keyserverInfos, [operation]),
};
} }
return state; return state;
} }