[keyserver] move mark_prekey_as_published calls inside of publishPrekeysToIdentity
ClosedPublic
Actions

Authored by varun on Jun 14 2024, 11:29 AM.

Details

Reviewers

ashoat

Commits

rCOMMb7ba804bc704: [keyserver] move mark_prekey_as_published calls inside of…

Summary

we always call mark_prekey_as_published after calling publishPrekeysToIdentity (except in an old migration, which won't be run again), so we can just move the call inside the function.

Depends on D12442

Test Plan

generated new unpublished prekeys and called validateAndUploadAccountPrekeys, confirmed that the prekeys were uploaded to identity and marked as published

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Jun 14 2024, 11:29 AM

Herald added a subscriber: tomek. · View Herald TranscriptJun 14 2024, 11:29 AM

Harbormaster completed remote builds in B29689: Diff 41342.Jun 14 2024, 11:46 AM

varun requested review of this revision.Jun 14 2024, 11:46 AM

ashoat accepted this revision.Jun 14 2024, 2:54 PM

This revision is now accepted and ready to land.Jun 14 2024, 2:54 PM

Closed by commit rCOMMb7ba804bc704: [keyserver] move mark_prekey_as_published calls inside of… (authored by varun). · Explain WhyJun 17 2024, 9:47 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMb7ba804bc704: [keyserver] move mark_prekey_as_published calls inside of….

Revision Contents
Changeset List

Path

Size

keyserver/

src/

utils/

olm-utils.js

15 lines

Diff 41413

View Options

keyserver/src/utils/olm-utils.js

Show First 20 Lines • Show All 1,485 Lines • ▼ Show 20 Lines	\| {
}		}
\| {		\| {
+type: 'FIND_USER_IDENTITIES_FAILED',		+type: 'FIND_USER_IDENTITIES_FAILED',
+error: true,		+error: true,
+payload: Error,		+payload: Error,
+loadingInfo: LoadingInfo,		+loadingInfo: LoadingInfo,
}		}
\| {		\| {
		+type: 'VERSION_SUPPORTED_BY_IDENTITY_STARTED',
		+loadingInfo?: LoadingInfo,
		+payload?: void,
		}
		\| {
		+type: 'VERSION_SUPPORTED_BY_IDENTITY_SUCCESS',
		+payload: {
		+supported: boolean,
		},
		+loadingInfo: LoadingInfo,
		}
		\| {
		+type: 'VERSION_SUPPORTED_BY_IDENTITY_FAILED',
		+error: true,
		+payload: Error,
		+loadingInfo: LoadingInfo,
		}
		\| {
+type: 'FETCH_PENDING_UPDATES_STARTED',		+type: 'FETCH_PENDING_UPDATES_STARTED',
+loadingInfo?: LoadingInfo,		+loadingInfo?: LoadingInfo,
+payload?: void,		+payload?: void,
}		}
\| {		\| {
+type: 'FETCH_PENDING_UPDATES_SUCCESS',		+type: 'FETCH_PENDING_UPDATES_SUCCESS',
+payload: ClientStateSyncSocketResult,		+payload: ClientStateSyncSocketResult,
+loadingInfo: LoadingInfo,		+loadingInfo: LoadingInfo,
Show All 29 Lines

[keyserver] move mark_prekey_as_published calls inside of publishPrekeysToIdentityClosedPublicActions