Page MenuHomePhabricator
Differential D12406

[lib][native] add useVersionSupportedByIdentity hook and use it on native
ClosedPublic
Actions

Authored by varun on Wed, Jun 12, 8:22 AM.

Details

Reviewers
ashoat
Commits
rCOMM62c362d0a861: [lib][native] add useVersionSupportedByIdentity hook and use it on native
Summary

we should avoid calling commRustModule directly from VersionSupportedChecker

Depends on 12405

Test Plan

ran the iOS simulator and confirmed that the VERSION_SUPPORTED_BY_IDENTITY_STARTED and VERSION_SUPPORTED_BY_IDENTITY_SUCCESS actions were dispatched.

modified staging identity to set the min supported version to 1000, confirmed that the alert was displayed on simulator

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Wed, Jun 12, 8:22 AM
Herald added a subscriber: tomek. · View Herald TranscriptWed, Jun 12, 8:22 AM
Harbormaster completed remote builds in B29625: Diff 41244.Wed, Jun 12, 8:46 AM
varun requested review of this revision.Wed, Jun 12, 8:46 AM
ashoat accepted this revision.Wed, Jun 12, 9:49 AM
ashoat added inline comments.
lib/types/redux-types.js
1500 ↗(On Diff #41244)

Making the payload an object makes it easier to modify later

This revision is now accepted and ready to land.Wed, Jun 12, 9:49 AM
ashoat added a parent revision: D12405: [native][web][lib] add versionSupported method to IdentityServiceClient.Wed, Jun 12, 9:49 AM
varun added a child revision: D12407: [web] check if version is supported by identity service.Wed, Jun 12, 12:20 PM
varun updated this revision to Diff 41337.Fri, Jun 14, 8:00 AM

make success payload an object

Harbormaster failed remote builds in B29684: Diff 41337!Fri, Jun 14, 8:23 AM
Harbormaster completed remote builds in B29684: Diff 41337.Fri, Jun 14, 8:50 AM
Closed by commit rCOMM62c362d0a861: [lib][native] add useVersionSupportedByIdentity hook and use it on native (authored by varun). · Explain WhyMon, Jun 17, 9:47 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM62c362d0a861: [lib][native] add useVersionSupportedByIdentity hook and use it on native.

Revision Contents
Changeset List

PathSize
lib/
actions/
20 lines
types/
18 lines
native/
components/
22 lines

Diff 41403

View Options

lib/actions/user-actions.js

Loading...
View Options

lib/types/redux-types.js

Loading...
View Options

native/components/version-supported.react.js

Loading...