Page MenuHomePhabricator

[lib][native] add useVersionSupportedByIdentity hook and use it on native
ClosedPublic

Authored by varun on Jun 12 2024, 8:22 AM.
Tags
None
Referenced Files
F3410120: D12406.diff
Wed, Dec 4, 7:38 PM
Unknown Object (File)
Thu, Nov 28, 5:03 PM
Unknown Object (File)
Thu, Nov 28, 11:08 AM
Unknown Object (File)
Thu, Nov 28, 10:53 AM
Unknown Object (File)
Sun, Nov 24, 12:38 AM
Unknown Object (File)
Thu, Nov 14, 8:48 AM
Unknown Object (File)
Mon, Nov 11, 7:48 AM
Unknown Object (File)
Mon, Nov 11, 7:28 AM
Subscribers

Details

Summary

we should avoid calling commRustModule directly from VersionSupportedChecker

Depends on 12405

Test Plan

ran the iOS simulator and confirmed that the VERSION_SUPPORTED_BY_IDENTITY_STARTED and VERSION_SUPPORTED_BY_IDENTITY_SUCCESS actions were dispatched.

modified staging identity to set the min supported version to 1000, confirmed that the alert was displayed on simulator

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun requested review of this revision.Jun 12 2024, 8:46 AM
ashoat added inline comments.
lib/types/redux-types.js
1500

Making the payload an object makes it easier to modify later

This revision is now accepted and ready to land.Jun 12 2024, 9:49 AM

make success payload an object