Rename new_content_prekeys and new_notif_prekeys
ClosedPublic
Actions

Authored by varun on Jun 14 2024, 8:48 AM.

Details

Reviewers

bartek
ashoat

Commits

rCOMM284294086cce: Rename new_content_prekeys and new_notif_prekeys

Summary

We only upload one of each type of prekey, so these fields should not be plural

Depends on D12436

Test Plan

ran flow, checked all invocations of RefreshUserPrekeys to make sure client code reflected the field name changes

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Jun 14 2024, 8:48 AM

Herald added a subscriber: tomek. · View Herald TranscriptJun 14 2024, 8:48 AM

fix variable names in identity

shared/protos/identity_auth.proto
86–92 ↗	(On Diff #41340)	keep lines under 80 characters
shared/protos/identity_unauth.proto
70–71 ↗	(On Diff #41340)	unrelated formatting change to match style guide

Harbormaster failed remote builds in B29686: Diff 41339!Jun 14 2024, 9:11 AM

Harbormaster completed remote builds in B29687: Diff 41340.

varun requested review of this revision.Jun 14 2024, 9:13 AM

varun added a child revision: D12442: [keyserver] check if there are any unpublished prekeys and publish them during rotation.Jun 14 2024, 9:40 AM

Proto changes won't break compatibility, right?

This revision is now accepted and ready to land.Jun 14 2024, 2:39 PM

In D12441#353079, @ashoat wrote:

Proto changes won't break compatibility, right?

they will. we need to do a new staging release right after this stack is landed. we will also need to do a new keyserver release when we do the next identity prod release

Closed by commit rCOMM284294086cce: Rename new_content_prekeys and new_notif_prekeys (authored by varun). · Explain WhyJun 17 2024, 9:47 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM284294086cce: Rename new_content_prekeys and new_notif_prekeys.

we will also need to do a new keyserver release when we do the next identity prod release

Next keyserver release includes a major migration that will probs take 15-30min to process, so I'm planning to do it late at night. Does that mean the identity release needs to happen late at night as well? Will any bad things happen if I deploy keyserver without identity being updated as well?

In D12441#353480, @ashoat wrote:

we will also need to do a new keyserver release when we do the next identity prod release

Next keyserver release includes a major migration that will probs take 15-30min to process, so I'm planning to do it late at night. Does that mean the identity release needs to happen late at night as well? Will any bad things happen if I deploy keyserver without identity being updated as well?

your keyserver will not be able to send new prekeys to identity during prekey rotation if you deploy keyserver without identity being updated as well. maybe this is fine? we could manually run the prekey rotation cron job the following morning after we do the identity prod release. we could also exclude this commit (2842940) from the keyserver release and then do a separate keyserver release with just this commit during the day at the same time as the identity prod release