Page MenuHomePhabricator
Differential D12401

[identity] dedup "unexpected message data" tonic message
ClosedPublic
Actions

Authored by varun on Jun 12 2024, 8:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 23, 1:12 AM
Unknown Object (File)
Feb 28 2025, 2:25 PM
Unknown Object (File)
Feb 28 2025, 2:25 PM
Unknown Object (File)
Feb 6 2025, 9:07 AM
Unknown Object (File)
Feb 3 2025, 11:13 AM
Unknown Object (File)
Jan 30 2025, 2:53 PM
Unknown Object (File)
Jan 30 2025, 2:53 PM
Unknown Object (File)
Jan 5 2025, 8:11 AM
View All 84 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
Commits
rCOMMf040950485cc: [identity] dedup "unexpected message data" tonic message
Summary

there are a lot of tonic status messages that need to be converted to snake_case and dedup'd.

i've arbitrarily broken this work up into chunks to make it easier to review

Test Plan

git grep for the old status messages, change client error handling where needed

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
services/
identity/
src/
5 lines
37 lines

Diff 41398

View Options

services/identity/src/constants.rs

Show All 17 Linesimport {
messageKey, messageKey,
robotextForMessageInfo, robotextForMessageInfo,
sortMessageInfoList, sortMessageInfoList,
} from '../shared/message-utils.js'; } from '../shared/message-utils.js';
import { messageSpecs } from '../shared/messages/message-specs.js'; import { messageSpecs } from '../shared/messages/message-specs.js';
import { import {
getSidebarItems, getSidebarItems,
getAllInitialSidebarItems, getAllInitialSidebarItems,
getAllFinalSidebarItems, getCandidateSidebarItemsForThreadList,
type SidebarItem, type SidebarItem,
} from '../shared/sidebar-item-utils.js'; } from '../shared/sidebar-item-utils.js';
import { threadInChatList, threadIsPending } from '../shared/thread-utils.js'; import { threadInChatList, threadIsPending } from '../shared/thread-utils.js';
import { messageTypes } from '../types/message-types-enum.js'; import { messageTypes } from '../types/message-types-enum.js';
import { import {
type ComposableMessageInfo, type ComposableMessageInfo,
isComposableMessageType, isComposableMessageType,
type LocalMessageInfo, type LocalMessageInfo,
▲ Show 20 Lines • Show All 71 Lines • ▼ Show 20 Lines threadInfo => {
type: 'chatThreadItem', type: 'chatThreadItem',
threadInfo, threadInfo,
mostRecentNonLocalMessage, mostRecentNonLocalMessage,
}; };
const getFinalChatThreadItem = async () => { const getFinalChatThreadItem = async () => {
const lastUpdatedTimePromise = lastUpdatedTime(); const lastUpdatedTimePromise = lastUpdatedTime();
const candidateSidebarItemsPromise =
getCandidateSidebarItemsForThreadList(sidebars);
const lastUpdatedTimeIncludingSidebarsPromise = (async () => { const lastUpdatedTimeIncludingSidebarsPromise = (async () => {
const lastUpdatedTimePromises = [ const candidateSidebarItems = await candidateSidebarItemsPromise;
lastUpdatedTimePromise, const lastUpdatedTimes = candidateSidebarItems.map(
...sidebars.map(sidebar => sidebar.lastUpdatedTime()), sidebarItem => sidebarItem.lastUpdatedTime,
]; );
const lastUpdatedTimes = await Promise.all(lastUpdatedTimePromises);
const max = lastUpdatedTimes.reduce((a, b) => Math.max(a, b), -1); const max = lastUpdatedTimes.reduce((a, b) => Math.max(a, b), -1);
return max; return max;
})(); })();
const [ const [
lastUpdatedTimeResult, lastUpdatedTimeResult,
lastUpdatedTimeIncludingSidebars, lastUpdatedTimeIncludingSidebars,
allSidebarItems, candidateSidebarItems,
] = await Promise.all([ ] = await Promise.all([
lastUpdatedTimePromise, lastUpdatedTimePromise,
lastUpdatedTimeIncludingSidebarsPromise, lastUpdatedTimeIncludingSidebarsPromise,
getAllFinalSidebarItems(sidebars), candidateSidebarItemsPromise,
]); ]);
return { return {
...chatThreadItemBase, ...chatThreadItemBase,
sidebars: getSidebarItems(allSidebarItems), sidebars: getSidebarItems(candidateSidebarItems),
lastUpdatedTime: lastUpdatedTimeResult, lastUpdatedTime: lastUpdatedTimeResult,
lastUpdatedTimeIncludingSidebars: lastUpdatedTimeIncludingSidebars, lastUpdatedTimeIncludingSidebars: lastUpdatedTimeIncludingSidebars,
}; };
}; };
const lastUpdatedAtLeastTimeIncludingSidebars = const lastUpdatedAtLeastTimeIncludingSidebars =
sidebars.length > 0 sidebars.length > 0
? Math.max(lastUpdatedAtLeastTime, sidebars[0].lastUpdatedAtLeastTime) ? Math.max(lastUpdatedAtLeastTime, sidebars[0].lastUpdatedAtLeastTime)
▲ Show 20 Lines • Show All 639 Lines • Show Last 20 Lines
View Options

services/identity/src/grpc_utils.rs

Show All 17 Linesimport {
messageKey, messageKey,
robotextForMessageInfo, robotextForMessageInfo,
sortMessageInfoList, sortMessageInfoList,
} from '../shared/message-utils.js'; } from '../shared/message-utils.js';
import { messageSpecs } from '../shared/messages/message-specs.js'; import { messageSpecs } from '../shared/messages/message-specs.js';
import { import {
getSidebarItems, getSidebarItems,
getAllInitialSidebarItems, getAllInitialSidebarItems,
getAllFinalSidebarItems, getCandidateSidebarItemsForThreadList,
type SidebarItem, type SidebarItem,
} from '../shared/sidebar-item-utils.js'; } from '../shared/sidebar-item-utils.js';
import { threadInChatList, threadIsPending } from '../shared/thread-utils.js'; import { threadInChatList, threadIsPending } from '../shared/thread-utils.js';
import { messageTypes } from '../types/message-types-enum.js'; import { messageTypes } from '../types/message-types-enum.js';
import { import {
type ComposableMessageInfo, type ComposableMessageInfo,
isComposableMessageType, isComposableMessageType,
type LocalMessageInfo, type LocalMessageInfo,
▲ Show 20 Lines • Show All 71 Lines • ▼ Show 20 Lines threadInfo => {
type: 'chatThreadItem', type: 'chatThreadItem',
threadInfo, threadInfo,
mostRecentNonLocalMessage, mostRecentNonLocalMessage,
}; };
const getFinalChatThreadItem = async () => { const getFinalChatThreadItem = async () => {
const lastUpdatedTimePromise = lastUpdatedTime(); const lastUpdatedTimePromise = lastUpdatedTime();
const candidateSidebarItemsPromise =
getCandidateSidebarItemsForThreadList(sidebars);
const lastUpdatedTimeIncludingSidebarsPromise = (async () => { const lastUpdatedTimeIncludingSidebarsPromise = (async () => {
const lastUpdatedTimePromises = [ const candidateSidebarItems = await candidateSidebarItemsPromise;
lastUpdatedTimePromise, const lastUpdatedTimes = candidateSidebarItems.map(
...sidebars.map(sidebar => sidebar.lastUpdatedTime()), sidebarItem => sidebarItem.lastUpdatedTime,
]; );
const lastUpdatedTimes = await Promise.all(lastUpdatedTimePromises);
const max = lastUpdatedTimes.reduce((a, b) => Math.max(a, b), -1); const max = lastUpdatedTimes.reduce((a, b) => Math.max(a, b), -1);
return max; return max;
})(); })();
const [ const [
lastUpdatedTimeResult, lastUpdatedTimeResult,
lastUpdatedTimeIncludingSidebars, lastUpdatedTimeIncludingSidebars,
allSidebarItems, candidateSidebarItems,
] = await Promise.all([ ] = await Promise.all([
lastUpdatedTimePromise, lastUpdatedTimePromise,
lastUpdatedTimeIncludingSidebarsPromise, lastUpdatedTimeIncludingSidebarsPromise,
getAllFinalSidebarItems(sidebars), candidateSidebarItemsPromise,
]); ]);
return { return {
...chatThreadItemBase, ...chatThreadItemBase,
sidebars: getSidebarItems(allSidebarItems), sidebars: getSidebarItems(candidateSidebarItems),
lastUpdatedTime: lastUpdatedTimeResult, lastUpdatedTime: lastUpdatedTimeResult,
lastUpdatedTimeIncludingSidebars: lastUpdatedTimeIncludingSidebars, lastUpdatedTimeIncludingSidebars: lastUpdatedTimeIncludingSidebars,
}; };
}; };
const lastUpdatedAtLeastTimeIncludingSidebars = const lastUpdatedAtLeastTimeIncludingSidebars =
sidebars.length > 0 sidebars.length > 0
? Math.max(lastUpdatedAtLeastTime, sidebars[0].lastUpdatedAtLeastTime) ? Math.max(lastUpdatedAtLeastTime, sidebars[0].lastUpdatedAtLeastTime)
▲ Show 20 Lines • Show All 639 Lines • Show Last 20 Lines