[native][web][lib] add versionSupported method to IdentityServiceClient
ClosedPublic
Actions

Authored by varun on Wed, Jun 12, 8:15 AM.

Details

Reviewers

ashoat

Commits

rCOMM1351324c3760: [native][web][lib] add versionSupported method to IdentityServiceClient

Summary

Depends on 12404

Initially, we just needed to call versionSupported on native. Now, we want to call it on both web and native. Before that, we should add this method to the IdentityServiceClient so we can call it from lib/actions/user-actions.js (next diff)

Test Plan

tested in next diff by dispatching action on native that calls this method

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Wed, Jun 12, 8:15 AM

Herald added a subscriber: tomek. · View Herald TranscriptWed, Jun 12, 8:15 AM

Harbormaster completed remote builds in B29624: Diff 41243.Wed, Jun 12, 8:41 AM

varun requested review of this revision.Wed, Jun 12, 8:41 AM

ashoat added inline comments.Wed, Jun 12, 9:44 AM

web/components/identity-ping.react.js
19 ↗	(On Diff #41243)	I think using the term "ping" in this assignment doesn't make much sense In general I wonder if the term should be used in this file at all Should we replace this with something like `VersionSupported` from `native`? Is that tracked anywhere?

ashoat requested changes to this revision.Wed, Jun 12, 9:44 AM

ashoat added a parent revision: D12404: [services] convert more tonic status messages to snake_case and dedup.

ashoat added inline comments.

web/grpc/identity-service-client-wrapper.js
674 ↗	(On Diff #41243)	This doesn't seem right... don't you remove `.ping` in `IdentityServiceClient` above?

This revision now requires changes to proceed.Wed, Jun 12, 9:45 AM

ashoat added a child revision: D12406: [lib][native] add useVersionSupportedByIdentity hook and use it on native.Wed, Jun 12, 9:49 AM

varun requested review of this revision.Wed, Jun 12, 12:37 PM

varun added inline comments.

web/components/identity-ping.react.js
19 ↗	(On Diff #41243)	this change was just to make sure nothing broke when i changed the IdentityServiceClient interface I remove the entire component in D12408 I introduce an identity version supported check in `MinVersionHandler` in D12407
web/grpc/identity-service-client-wrapper.js
674 ↗	(On Diff #41243)	`ping` is the RPC name. we use it to check if the client version is supported (identity will send back an error if it's not supported, otherwise sends back `Empty`)