Page MenuHomePhabricator

[native][web][lib] add versionSupported method to IdentityServiceClient
ClosedPublic

Authored by varun on Jun 12 2024, 8:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 7:59 PM
Unknown Object (File)
Sun, Nov 10, 5:29 PM
Unknown Object (File)
Sun, Nov 10, 2:17 AM
Unknown Object (File)
Nov 3 2024, 10:15 PM
Unknown Object (File)
Nov 3 2024, 9:25 AM
Unknown Object (File)
Nov 1 2024, 1:29 PM
Unknown Object (File)
Oct 5 2024, 6:43 AM
Unknown Object (File)
Oct 5 2024, 6:43 AM
Subscribers

Details

Summary

Depends on 12404

Initially, we just needed to call versionSupported on native. Now, we want to call it on both web and native. Before that, we should add this method to the IdentityServiceClient so we can call it from lib/actions/user-actions.js (next diff)

Test Plan

tested in next diff by dispatching action on native that calls this method

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun requested review of this revision.Jun 12 2024, 8:41 AM
web/components/identity-ping.react.js
19

I think using the term "ping" in this assignment doesn't make much sense

In general I wonder if the term should be used in this file at all

Should we replace this with something like VersionSupported from native? Is that tracked anywhere?

ashoat requested changes to this revision.Jun 12 2024, 9:44 AM
ashoat added inline comments.
web/grpc/identity-service-client-wrapper.js
674

This doesn't seem right... don't you remove .ping in IdentityServiceClient above?

This revision now requires changes to proceed.Jun 12 2024, 9:45 AM
varun added inline comments.
web/components/identity-ping.react.js
19

this change was just to make sure nothing broke when i changed the IdentityServiceClient interface

I remove the entire component in D12408

I introduce an identity version supported check in MinVersionHandler in D12407

web/grpc/identity-service-client-wrapper.js
674

ping is the RPC name. we use it to check if the client version is supported (identity will send back an error if it's not supported, otherwise sends back Empty)

This revision is now accepted and ready to land.Jun 12 2024, 12:40 PM