Page MenuHomePhabricator
Differential D12407

[web] check if version is supported by identity service
ClosedPublic
Actions

Authored by varun on Jun 12 2024, 12:20 PM.
Tags
None
Referenced Files
F3146601: D12407.diff
Mon, Nov 4, 3:01 AM
Unknown Object (File)
Fri, Nov 1, 1:29 PM
Unknown Object (File)
Oct 5 2024, 6:43 AM
Unknown Object (File)
Oct 5 2024, 6:43 AM
Unknown Object (File)
Oct 5 2024, 6:43 AM
Unknown Object (File)
Oct 5 2024, 6:43 AM
Unknown Object (File)
Oct 5 2024, 6:42 AM
Unknown Object (File)
Sep 27 2024, 9:19 PM
View All 46 Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMMca53cc98ef66: [web] check if version is supported by identity service
Summary

call the versionSupported identity client method to check if the client code version is supported. if it's not supported by identity and the client is logged in, log out. regardless of whether or not client is logged in, display modal instructing user to reload/refresh.

Depends on D12406

Test Plan
  • bumped min version supported on staging identity to 1000, confirmed that modal was displayed and i was logged out on web
  • modified function returned by useVersionSupportedByIdentity to always throw, confirmed that log appeared in console but user was not logged out and modal was not displayed

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Jun 12 2024, 12:20 PM
Herald added a subscriber: tomek. · View Herald TranscriptJun 12 2024, 12:20 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 12 2024, 12:22 PM
Harbormaster failed remote builds in B29629: Diff 41250!
varun added a child revision: D12408: [web] remove ping component.Jun 12 2024, 12:29 PM
varun mentioned this in D12405: [native][web][lib] add versionSupported method to IdentityServiceClient.Jun 12 2024, 12:37 PM
Harbormaster completed remote builds in B29629: Diff 41250.Jun 12 2024, 12:47 PM
varun requested review of this revision.Jun 12 2024, 12:47 PM
ashoat requested changes to this revision.Jun 12 2024, 12:50 PM
ashoat added inline comments.
web/components/version-handler.react.js
28 ↗(On Diff #41250)

Nit: can we name this isClientVersionUnsupportedByAnyKeyserver? (added "any")

66 ↗(On Diff #41250)

We're going to call this ping endpoint a ton, largely due to the dependency on callLogOut, which will get recalculated every time the keyserver <> client socket gets reset (happens a lot on prod, generally a couple times every 10s)

I'd like to suggest a different approach:

  1. Separate effect that calls callVersionSupportedByIdentity and sets some state to true
  2. This effect just checks that state, instead of calling identity directly
This revision now requires changes to proceed.Jun 12 2024, 12:50 PM
varun updated this revision to Diff 41338.Jun 14 2024, 8:00 AM

address feedback

Harbormaster completed remote builds in B29685: Diff 41338.Jun 14 2024, 8:17 AM
ashoat accepted this revision.Jun 14 2024, 2:38 PM
This revision is now accepted and ready to land.Jun 14 2024, 2:38 PM
Closed by commit rCOMMca53cc98ef66: [web] check if version is supported by identity service (authored by varun). · Explain WhyJun 17 2024, 9:47 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMca53cc98ef66: [web] check if version is supported by identity service.

Revision Contents
Changeset List

PathSize
web/
components/
74 lines

Diff 41406

View Options

web/components/version-handler.react.js

Loading...