Page MenuHomePhabricator
Differential D12435

[identity] last tonic status message conversions
ClosedPublic
Actions

Authored by varun on Jun 13 2024, 1:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 28, 2:26 PM
Unknown Object (File)
Fri, Feb 28, 2:25 PM
Unknown Object (File)
Feb 6 2025, 9:07 AM
Unknown Object (File)
Feb 3 2025, 11:13 AM
Unknown Object (File)
Jan 30 2025, 2:54 PM
Unknown Object (File)
Jan 30 2025, 2:54 PM
Unknown Object (File)
Jan 19 2025, 11:24 PM
Unknown Object (File)
Dec 28 2024, 10:24 AM
View All 53 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
Commits
rCOMMa3512b23fe43: [identity] last tonic status message conversions
Summary

Depends on D12434

there are a lot of tonic status messages that need to be converted to snake_case and dedup'd.

i've arbitrarily broken this work up into chunks to make it easier to review

this is the last diff to resolve https://linear.app/comm/issue/ENG-6477/convert-identity-service-errors-to-snake-case-and-dedup-them

Test Plan

git grep for the old status messages, change client error handling where needed

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
account/
2 lines
profile/
2 lines
services/
identity/
src/
5 lines
8 lines
grpc_services/
8 lines
21 lines
2 lines
2 lines
shared/
comm-opaque2/
src/
10 lines
10 lines
grpc_clients/
src/
identity/
7 lines
7 lines
web/
account/
2 lines

Diff 41409

View Options

native/account/log-in-panel.react.js

Show First 20 Lines • Show All 1,485 Lines • ▼ Show 20 Lines | {
} }
| { | {
+type: 'FIND_USER_IDENTITIES_FAILED', +type: 'FIND_USER_IDENTITIES_FAILED',
+error: true, +error: true,
+payload: Error, +payload: Error,
+loadingInfo: LoadingInfo, +loadingInfo: LoadingInfo,
} }
| { | {
+type: 'VERSION_SUPPORTED_BY_IDENTITY_STARTED',
+loadingInfo?: LoadingInfo,
+payload?: void,
}
| {
+type: 'VERSION_SUPPORTED_BY_IDENTITY_SUCCESS',
+payload: {
+supported: boolean,
},
+loadingInfo: LoadingInfo,
}
| {
+type: 'VERSION_SUPPORTED_BY_IDENTITY_FAILED',
+error: true,
+payload: Error,
+loadingInfo: LoadingInfo,
}
| {
+type: 'FETCH_PENDING_UPDATES_STARTED', +type: 'FETCH_PENDING_UPDATES_STARTED',
+loadingInfo?: LoadingInfo, +loadingInfo?: LoadingInfo,
+payload?: void, +payload?: void,
} }
| { | {
+type: 'FETCH_PENDING_UPDATES_SUCCESS', +type: 'FETCH_PENDING_UPDATES_SUCCESS',
+payload: ClientStateSyncSocketResult, +payload: ClientStateSyncSocketResult,
+loadingInfo: LoadingInfo, +loadingInfo: LoadingInfo,
Show All 29 Lines
View Options

native/profile/delete-account.react.js

Show First 20 Lines • Show All 1,485 Lines • ▼ Show 20 Lines | {
} }
| { | {
+type: 'FIND_USER_IDENTITIES_FAILED', +type: 'FIND_USER_IDENTITIES_FAILED',
+error: true, +error: true,
+payload: Error, +payload: Error,
+loadingInfo: LoadingInfo, +loadingInfo: LoadingInfo,
} }
| { | {
+type: 'VERSION_SUPPORTED_BY_IDENTITY_STARTED',
+loadingInfo?: LoadingInfo,
+payload?: void,
}
| {
+type: 'VERSION_SUPPORTED_BY_IDENTITY_SUCCESS',
+payload: {
+supported: boolean,
},
+loadingInfo: LoadingInfo,
}
| {
+type: 'VERSION_SUPPORTED_BY_IDENTITY_FAILED',
+error: true,
+payload: Error,
+loadingInfo: LoadingInfo,
}
| {
+type: 'FETCH_PENDING_UPDATES_STARTED', +type: 'FETCH_PENDING_UPDATES_STARTED',
+loadingInfo?: LoadingInfo, +loadingInfo?: LoadingInfo,
+payload?: void, +payload?: void,
} }
| { | {
+type: 'FETCH_PENDING_UPDATES_SUCCESS', +type: 'FETCH_PENDING_UPDATES_SUCCESS',
+payload: ClientStateSyncSocketResult, +payload: ClientStateSyncSocketResult,
+loadingInfo: LoadingInfo, +loadingInfo: LoadingInfo,
Show All 29 Lines
View Options

services/identity/src/constants.rs

Show First 20 Lines • Show All 1,485 Lines • ▼ Show 20 Lines | {
} }
| { | {
+type: 'FIND_USER_IDENTITIES_FAILED', +type: 'FIND_USER_IDENTITIES_FAILED',
+error: true, +error: true,
+payload: Error, +payload: Error,
+loadingInfo: LoadingInfo, +loadingInfo: LoadingInfo,
} }
| { | {
+type: 'VERSION_SUPPORTED_BY_IDENTITY_STARTED',
+loadingInfo?: LoadingInfo,
+payload?: void,
}
| {
+type: 'VERSION_SUPPORTED_BY_IDENTITY_SUCCESS',
+payload: {
+supported: boolean,
},
+loadingInfo: LoadingInfo,
}
| {
+type: 'VERSION_SUPPORTED_BY_IDENTITY_FAILED',
+error: true,
+payload: Error,
+loadingInfo: LoadingInfo,
}
| {
+type: 'FETCH_PENDING_UPDATES_STARTED', +type: 'FETCH_PENDING_UPDATES_STARTED',
+loadingInfo?: LoadingInfo, +loadingInfo?: LoadingInfo,
+payload?: void, +payload?: void,
} }
| { | {
+type: 'FETCH_PENDING_UPDATES_SUCCESS', +type: 'FETCH_PENDING_UPDATES_SUCCESS',
+payload: ClientStateSyncSocketResult, +payload: ClientStateSyncSocketResult,
+loadingInfo: LoadingInfo, +loadingInfo: LoadingInfo,
Show All 29 Lines
View Options

services/identity/src/device_list.rs

Show First 20 Lines • Show All 1,485 Lines • ▼ Show 20 Lines | {
} }
| { | {
+type: 'FIND_USER_IDENTITIES_FAILED', +type: 'FIND_USER_IDENTITIES_FAILED',
+error: true, +error: true,
+payload: Error, +payload: Error,
+loadingInfo: LoadingInfo, +loadingInfo: LoadingInfo,
} }
| { | {
+type: 'VERSION_SUPPORTED_BY_IDENTITY_STARTED',
+loadingInfo?: LoadingInfo,
+payload?: void,
}
| {
+type: 'VERSION_SUPPORTED_BY_IDENTITY_SUCCESS',
+payload: {
+supported: boolean,
},
+loadingInfo: LoadingInfo,
}
| {
+type: 'VERSION_SUPPORTED_BY_IDENTITY_FAILED',
+error: true,
+payload: Error,
+loadingInfo: LoadingInfo,
}
| {
+type: 'FETCH_PENDING_UPDATES_STARTED', +type: 'FETCH_PENDING_UPDATES_STARTED',
+loadingInfo?: LoadingInfo, +loadingInfo?: LoadingInfo,
+payload?: void, +payload?: void,
} }
| { | {
+type: 'FETCH_PENDING_UPDATES_SUCCESS', +type: 'FETCH_PENDING_UPDATES_SUCCESS',
+payload: ClientStateSyncSocketResult, +payload: ClientStateSyncSocketResult,
+loadingInfo: LoadingInfo, +loadingInfo: LoadingInfo,
Show All 29 Lines
View Options

services/identity/src/grpc_services/shared.rs

Show First 20 Lines • Show All 1,485 Lines • ▼ Show 20 Lines | {
} }
| { | {
+type: 'FIND_USER_IDENTITIES_FAILED', +type: 'FIND_USER_IDENTITIES_FAILED',
+error: true, +error: true,
+payload: Error, +payload: Error,
+loadingInfo: LoadingInfo, +loadingInfo: LoadingInfo,
} }
| { | {
+type: 'VERSION_SUPPORTED_BY_IDENTITY_STARTED',
+loadingInfo?: LoadingInfo,
+payload?: void,
}
| {
+type: 'VERSION_SUPPORTED_BY_IDENTITY_SUCCESS',
+payload: {
+supported: boolean,
},
+loadingInfo: LoadingInfo,
}
| {
+type: 'VERSION_SUPPORTED_BY_IDENTITY_FAILED',
+error: true,
+payload: Error,
+loadingInfo: LoadingInfo,
}
| {
+type: 'FETCH_PENDING_UPDATES_STARTED', +type: 'FETCH_PENDING_UPDATES_STARTED',
+loadingInfo?: LoadingInfo, +loadingInfo?: LoadingInfo,
+payload?: void, +payload?: void,
} }
| { | {
+type: 'FETCH_PENDING_UPDATES_SUCCESS', +type: 'FETCH_PENDING_UPDATES_SUCCESS',
+payload: ClientStateSyncSocketResult, +payload: ClientStateSyncSocketResult,
+loadingInfo: LoadingInfo, +loadingInfo: LoadingInfo,
Show All 29 Lines
View Options

services/identity/src/reserved_users.rs

Loading...
View Options

services/identity/src/siwe.rs

Loading...
View Options

services/identity/src/tunnelbroker.rs

Loading...
View Options

shared/comm-opaque2/src/error.rs

Loading...
View Options

shared/comm-opaque2/src/grpc.rs

Loading...
View Options

shared/grpc_clients/src/identity/authenticated.rs

Loading...
View Options

shared/grpc_clients/src/identity/shared.rs

Loading...
View Options

web/account/traditional-login-form.react.js

Loading...