Page MenuHomePhabricator

Rename new_content_prekeys and new_notif_prekeys
ClosedPublic

Authored by varun on Jun 14 2024, 8:48 AM.
Tags
None
Referenced Files
F3408946: D12441.diff
Wed, Dec 4, 2:33 PM
Unknown Object (File)
Mon, Dec 2, 8:07 PM
Unknown Object (File)
Mon, Nov 11, 4:27 AM
Unknown Object (File)
Nov 1 2024, 9:05 PM
Unknown Object (File)
Oct 27 2024, 12:54 AM
Unknown Object (File)
Oct 22 2024, 10:19 PM
Unknown Object (File)
Oct 5 2024, 6:09 AM
Unknown Object (File)
Oct 5 2024, 6:09 AM
Subscribers

Details

Summary

We only upload one of each type of prekey, so these fields should not be plural

Depends on D12436

Test Plan

ran flow, checked all invocations of RefreshUserPrekeys to make sure client code reflected the field name changes

Diff Detail

Repository
rCOMM Comm
Branch
webping (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

fix variable names in identity

shared/protos/identity_auth.proto
86–92 ↗(On Diff #41340)

keep lines under 80 characters

shared/protos/identity_unauth.proto
70–71 ↗(On Diff #41340)

unrelated formatting change to match style guide

varun requested review of this revision.Jun 14 2024, 9:13 AM

Proto changes won't break compatibility, right?

This revision is now accepted and ready to land.Jun 14 2024, 2:39 PM

Proto changes won't break compatibility, right?

they will. we need to do a new staging release right after this stack is landed. we will also need to do a new keyserver release when we do the next identity prod release

we will also need to do a new keyserver release when we do the next identity prod release

Next keyserver release includes a major migration that will probs take 15-30min to process, so I'm planning to do it late at night. Does that mean the identity release needs to happen late at night as well? Will any bad things happen if I deploy keyserver without identity being updated as well?

we will also need to do a new keyserver release when we do the next identity prod release

Next keyserver release includes a major migration that will probs take 15-30min to process, so I'm planning to do it late at night. Does that mean the identity release needs to happen late at night as well? Will any bad things happen if I deploy keyserver without identity being updated as well?

your keyserver will not be able to send new prekeys to identity during prekey rotation if you deploy keyserver without identity being updated as well. maybe this is fine? we could manually run the prekey rotation cron job the following morning after we do the identity prod release. we could also exclude this commit (2842940) from the keyserver release and then do a separate keyserver release with just this commit during the day at the same time as the identity prod release