Page MenuHomePhabricator
Differential D11791

[native] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings`
ClosedPublic
Actions

Authored by atul on Apr 25 2024, 2:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 3, 2:47 AM
Unknown Object (File)
Mon, Oct 28, 1:46 PM
Unknown Object (File)
Sat, Oct 12, 4:03 PM
Unknown Object (File)
Sat, Oct 12, 4:03 PM
Unknown Object (File)
Sat, Oct 12, 4:03 PM
Unknown Object (File)
Sat, Oct 12, 4:02 PM
Unknown Object (File)
Sat, Oct 12, 4:02 PM
Unknown Object (File)
Sep 29 2024, 12:33 AM
View All 51 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
Commits
rCOMM136bd75e5a11: [native] Replace `threadHasPermission` with `useThreadHasPermission` in…
Summary

Similar to D11790, but for ThreadSettings

Depends on D11790

Test Plan

flow + close reading

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Apr 25 2024, 2:00 PM
atul added a child revision: D11792: [lib] Turn `canPromoteSidebar` to `useCanPromoteSidebar` hook.Apr 25 2024, 2:03 PM
Harbormaster completed remote builds in B28487: Diff 39517.Apr 25 2024, 2:26 PM
atul requested review of this revision.Apr 25 2024, 2:26 PM
ashoat accepted this revision.Apr 25 2024, 2:29 PM
This revision is now accepted and ready to land.Apr 25 2024, 2:29 PM
atul updated this revision to Diff 39575.Apr 26 2024, 11:43 AM

land

This revision was landed with ongoing or failed builds.Apr 26 2024, 11:46 AM
Closed by commit rCOMM136bd75e5a11: [native] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM136bd75e5a11: [native] Replace `threadHasPermission` with `useThreadHasPermission` in….
Harbormaster completed remote builds in B28528: Diff 39575.Apr 26 2024, 12:11 PM
atul mentioned this in D11816: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanEditMessage`.Apr 26 2024, 12:49 PM
atul mentioned this in rCOMMbf7178f18877: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in….May 2 2024, 9:59 AM

Revision Contents
Changeset List

PathSize
native/
chat/
settings/
107 lines

Diff 39575

View Options

native/chat/settings/thread-settings.react.js

Loading...