Paths

Table of Contentst

[lib] Turn `canPromoteSidebar` to `useCanPromoteSidebar` hook
ClosedPublic
Actions

Authored by atul on Apr 25 2024, 2:03 PM.

Details

Reviewers

ashoat
ginsu
tomek

Commits

rCOMM64ad347fd686: [lib] Turn `canPromoteSidebar` to `useCanPromoteSidebar` hook

Summary

Part of deprecating use of threadHasPermission on client.

Depends on D11791

Test Plan

flow + close reading

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D11792 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Apr 25 2024, 2:03 PM

Harbormaster completed remote builds in B28488: Diff 39518.Apr 25 2024, 2:30 PM

atul requested review of this revision.Apr 25 2024, 2:30 PM

ashoat accepted this revision.Apr 25 2024, 2:32 PM

ashoat added inline comments.

lib/hooks/promote-sidebar.react.js
34–37 ↗	(On Diff #39518)	Might as well combine all of these now

This revision is now accepted and ready to land.Apr 25 2024, 2:32 PM

atul added inline comments.Apr 26 2024, 11:47 AM

lib/hooks/promote-sidebar.react.js
34–37 ↗	(On Diff #39518)	Ah yeah that makes way more sense, will update

consolidate conditional

This revision was landed with ongoing or failed builds.Apr 26 2024, 12:12 PM

Closed by commit rCOMM64ad347fd686: [lib] Turn `canPromoteSidebar` to `useCanPromoteSidebar` hook (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM64ad347fd686: [lib] Turn `canPromoteSidebar` to `useCanPromoteSidebar` hook.

Harbormaster completed remote builds in B28532: Diff 39587.Apr 26 2024, 12:31 PM

atul added a child revision: D11816: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanEditMessage`.Apr 26 2024, 12:49 PM

Revision Contents
Changeset List

Path

Size

lib/

hooks/

promote-sidebar.react.js

23 lines

web/

modals/

threads/

notifications/

notifications-modal.react.js

12 lines

Diff 39587

View Options

lib/hooks/promote-sidebar.react.js