This differential enables user to skip siwe backup message generation. Additionally alert store is used to prevent the screen from appearing too frequently.
Details
Details
- Build the app
- Log in as SIWE user
- Ensure that there is a Skip button on a backup message screen.
- Click skip button. Ensure that screen disappears.
- Play with the app. Kill and re-open it multiple times. Ensure that screen doesn't appear again.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
| native/account/registration/missing-registration-data/missing-siwe-backup-message.react.js | ||
|---|---|---|
| 24 ↗ | (On Diff #39503) | Why do we need this state? Can't we just call props.navigation.goBack() directly in onSkip? |
Comment Actions
alert code looks good, pls make sure to respond + address @ashoat's comments before landing
| native/account/registration/missing-registration-data/missing-siwe-backup-message.react.js | ||
|---|---|---|
| 24 ↗ | (On Diff #39503) | Probably this state is not necessary and it is over engineering here. It looks like setSIWEBackupSecrets state is not necessary as well. |
| native/account/registration/missing-registration-data/missing-siwe-backup-message.react.js | ||
|---|---|---|
| 30 ↗ | (On Diff #39535) | It is always good to be more specific in the dep list, so that we can avoid unnecessary recomputations |
| 35 ↗ | (On Diff #39535) | |
| 41 ↗ | (On Diff #39535) | I wonder if you could just pass props.navigation.goBack here |
| native/account/registration/siwe-backup-message-creation.react.js | ||
| 33 ↗ | (On Diff #39535) | You might need to change this to => mixed in order for the last comment to work. In general accepting => mixed is a more flexible API... you don't actually care what is returned, you just want to call the function |