[lib] Narrow `canToggleMessagePin` and `useCanToggleMessagePin` types
ClosedPublic
Actions

Authored by atul on Apr 26 2024, 12:58 PM.

Details

Reviewers

ashoat
ginsu
tomek
varun

Commits

rCOMM2d4677a72526: [lib] Narrow `canToggleMessagePin` and `useCanToggleMessagePin` types

Summary

To make it clear which should be used in which scenario (RawThreadInfo vs ThreadInfo).

Depends on D11820

Test Plan

flow + close reading

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Apr 26 2024, 12:58 PM

Harbormaster completed remote builds in B28545: Diff 39601.Apr 26 2024, 1:36 PM

atul requested review of this revision.Apr 26 2024, 1:36 PM

ashoat accepted this revision.Apr 27 2024, 6:47 PM

This revision is now accepted and ready to land.Apr 27 2024, 6:47 PM

land

This revision was landed with ongoing or failed builds.May 3 2024, 1:01 PM

Closed by commit rCOMM2d4677a72526: [lib] Narrow `canToggleMessagePin` and `useCanToggleMessagePin` types (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM2d4677a72526: [lib] Narrow `canToggleMessagePin` and `useCanToggleMessagePin` types.

Harbormaster completed remote builds in B28645: Diff 39764.May 3 2024, 1:07 PM

Revision Contents
Changeset List

Path

Size

lib/

utils/

message-pinning-utils.js

6 lines

Diff 39768

View Options

lib/utils/message-pinning-utils.js

Show All 31 Lines	.questionText {
color: var(--white-100);		color: var(--white-100);
}		}

.icon {		.icon {
margin-left: 24px;		margin-left: 24px;
}		}

.answerContainer {		.answerContainer {
max-height: 0;		display: grid;
overflow: hidden;		grid-template-rows: 0fr;
		transition: grid-template-rows 500ms;
}		}

.activeAnswerContainer {		.activeAnswerContainer {
max-height: fit-content;		grid-template-rows: 1fr;
}		}

.answerText {		.answerText {
color: var(--white-100);		color: var(--white-100);
margin-top: 16px;		margin-top: 16px;
		overflow: hidden;
}		}

.link {		.link {
color: inherit;		color: inherit;
text-decoration: underline;		text-decoration: underline;
transition: color 150ms;		transition: color 150ms;
}		}

.link:hover {		.link:hover {
color: var(--violet-dark-100);		color: var(--violet-dark-100);
transition: color 150ms;		transition: color 150ms;
}		}

[lib] Narrow `canToggleMessagePin` and `useCanToggleMessagePin` typesClosedPublicActions