Page MenuHomePhabricator
Differential D12172

Inherit crate dependencies from workspace root
ClosedPublic
Actions

Authored by bartek on May 22 2024, 5:34 AM.
Tags
None
Referenced Files
F2067053: D12172.diff
Fri, Jun 21, 1:39 PM
Unknown Object (File)
Fri, Jun 14, 3:08 PM
Unknown Object (File)
Thu, Jun 13, 9:22 PM
Unknown Object (File)
Thu, Jun 13, 10:51 AM
Unknown Object (File)
Tue, Jun 11, 2:59 AM
Unknown Object (File)
Mon, Jun 10, 8:17 PM
Unknown Object (File)
Sun, Jun 9, 1:40 PM
Unknown Object (File)
Sun, Jun 9, 12:40 PM
View All 32 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
Commits
rCOMM95d8724f9dd2: Inherit crate dependencies from workspace root
Summary

Used a tool named cargo-autoinherit.
It automatically finds dependencies that have common version number across all workspace and hoists them to root Cargo.toml

Depends on D12171

Test Plan
  • cargo check --workspace
  • CI
  • Lockfile hasn't been changed - package versions are still the same

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.May 22 2024, 5:34 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 22 2024, 5:34 AM
bartek added a child revision: D12173: [backup] Remove unnecessary aws_types dependency.May 22 2024, 5:35 AM
Harbormaster failed remote builds in B29158: Diff 40529!May 22 2024, 5:37 AM
bartek updated this revision to Diff 40537.May 22 2024, 6:57 AM

Rebase

Harbormaster failed remote builds in B29166: Diff 40537!May 22 2024, 7:04 AM
bartek updated this revision to Diff 40538.May 22 2024, 7:07 AM

Rebase on fix

Harbormaster completed remote builds in B29167: Diff 40538.May 22 2024, 7:22 AM
bartek published this revision for review.May 22 2024, 7:32 AM
bartek edited the test plan for this revision. (Show Details)
varun accepted this revision.Fri, May 24, 10:16 AM

should we create backlog tasks for the crates that aren't being inherited from the workspace root? in particular, it would be great to get all our crates on the same version of tonic

This revision is now accepted and ready to land.Fri, May 24, 10:16 AM
bartek added a comment.Tue, May 28, 7:55 AM
In D12172#347646, @varun wrote:

should we create backlog tasks for the crates that aren't being inherited from the workspace root? in particular, it would be great to get all our crates on the same version of tonic

I've already created ENG-8176.

Closed by commit rCOMM95d8724f9dd2: Inherit crate dependencies from workspace root (authored by bartek). · Explain WhyTue, May 28, 8:12 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM95d8724f9dd2: Inherit crate dependencies from workspace root.

Revision Contents
Changeset List

PathSize
59 lines
keyserver/
addons/
rust-node-addon/
29 lines
services/
backup/
50 lines
blob/
44 lines
commtest/
36 lines
feature-flags/
24 lines
identity/
50 lines
reports/
46 lines
tunnelbroker/
30 lines
shared/
backup_client/
30 lines
comm-lib/
54 lines
comm-opaque2/
10 lines
grpc_clients/
10 lines
identity_search_messages/
4 lines
tunnelbroker_messages/
4 lines
websocket_messages/
4 lines

Diff 40538

View Options

Cargo.toml

Loading...
View Options

keyserver/addons/rust-node-addon/Cargo.toml

Loading...
View Options

services/backup/Cargo.toml

Loading...
View Options

services/blob/Cargo.toml

Loading...
View Options

services/commtest/Cargo.toml

Loading...
View Options

services/feature-flags/Cargo.toml

Loading...
View Options

services/identity/Cargo.toml

Loading...
View Options

services/reports/Cargo.toml

Loading...
View Options

services/tunnelbroker/Cargo.toml

Loading...
View Options

shared/backup_client/Cargo.toml

Loading...
View Options

shared/comm-lib/Cargo.toml

Loading...
View Options

shared/comm-opaque2/Cargo.toml

Loading...
View Options

shared/grpc_clients/Cargo.toml

Loading...
View Options

shared/identity_search_messages/Cargo.toml

Loading...
View Options

shared/tunnelbroker_messages/Cargo.toml

Loading...
View Options

shared/websocket_messages/Cargo.toml

Loading...