Paths

Table of Contentst

[identity][grpc_clients] Move PlatformMetadata to grpc_clients crate
ClosedPublic
Actions

Authored by bartek on Jun 3 2024, 5:39 AM.

Details

Reviewers

varun
marcin

Commits

rCOMM2e4d4738598b: [identity][grpc_clients] Move PlatformMetadata to grpc_clients crate

Summary

Decided to make PlatformMetadata shared between Identity Service and all clients.
This lets us avoid some code duplication.

Also added some helpers that will be handy in the very next diffs

Depends on D12280, D12274

Test Plan

Identity and all clients compile.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Jun 3 2024, 5:39 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 3 2024, 5:39 AM

Harbormaster failed remote builds in B29363: Diff 40848!Jun 3 2024, 5:42 AM

bartek added a child revision: D12283: [grpc_clients] Accept PlatformMetadata when creating client.Jun 3 2024, 5:42 AM

bartek published this revision for review.Jun 3 2024, 6:02 AM

Harbormaster completed remote builds in B29363: Diff 40848.Jun 3 2024, 8:04 AM

marcin added inline comments.Jun 4 2024, 9:20 AM

shared/grpc_clients/src/identity/shared.rs
8	Those two structures look exactly the same. What is the intention behind keeping them as separate definitions?

bartek added inline comments.Jun 6 2024, 12:09 AM

shared/grpc_clients/src/identity/shared.rs
8	Answered in https://phab.comm.dev/D12279#inline-72355

marcin accepted this revision.Jun 6 2024, 2:08 AM

This revision is now accepted and ready to land.Jun 6 2024, 2:08 AM

Closed by commit rCOMM2e4d4738598b: [identity][grpc_clients] Move PlatformMetadata to grpc_clients crate (authored by bartek). · Explain WhyJun 6 2024, 8:11 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM2e4d4738598b: [identity][grpc_clients] Move PlatformMetadata to grpc_clients crate.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

grpc_services/

shared.rs

8 lines

shared/

grpc_clients/

src/

identity/

shared.rs

31 lines

Diff 40848

View Options

services/identity/src/grpc_services/shared.rs