Paths

Table of Contentst

[grpc_clients] Accept PlatformMetadata when creating client
ClosedPublic
Actions

Authored by bartek on Jun 3 2024, 5:42 AM.

Details

Reviewers

varun
marcin

Commits

rCOMMf521baa6078a: [grpc_clients] Accept PlatformMetadata when creating client

Summary

Updated grpc_clients::get_auth_client and get_unauthenticated_client to accept

PlatformMetadata argument instead of separate values for code version and platform.

Updated all callsites across repo

Depends on D12282

Test Plan

CI
Keyserver, native_rust_library, commtest compilation
Performed several identity actions on clients (native + web) - printed metadata values server-side

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Jun 3 2024, 5:42 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 3 2024, 5:42 AM

Harbormaster failed remote builds in B29364: Diff 40849!Jun 3 2024, 5:47 AM

Commit missing places

Harbormaster completed remote builds in B29366: Diff 40851.Jun 3 2024, 6:24 AM

bartek published this revision for review.Jun 3 2024, 6:47 AM

marcin added a child revision: D12307: Add identity platform details to aux user store.Jun 4 2024, 7:13 AM

marcin added inline comments.Jun 4 2024, 9:23 AM

shared/grpc_clients/src/identity/unauthenticated/client.rs
21 ↗	(On Diff #40851)	Why is new object instead of `PLATFORM_METADATA` constant?

bartek added inline comments.Jun 4 2024, 9:39 AM

shared/grpc_clients/src/identity/unauthenticated/client.rs
21 ↗	(On Diff #40851)	This is a different crate. We cannot use a constant because this can be called by keyserver, native, or other services.

marcin accepted this revision.Jun 5 2024, 2:24 AM

This revision is now accepted and ready to land.Jun 5 2024, 2:24 AM

Closed by commit rCOMMf521baa6078a: [grpc_clients] Accept PlatformMetadata when creating client (authored by bartek). · Explain WhyJun 6 2024, 8:11 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMf521baa6078a: [grpc_clients] Accept PlatformMetadata when creating client.

Revision Contents
Changeset List

Path

Size

keyserver/

addons/

rust-node-addon/

src/

identity_client/

mod.rs

7 lines

native/

native_rust_library/

src/

identity.rs

31 lines

identity/

16 lines

13 lines

14 lines

19 lines

find_user_identities.rs

7 lines

43 lines

registration.rs

42 lines

x3dh.rs

19 lines

services/

commtest/

src/

identity/

device.rs

13 lines

tests/

identity_access_tokens_tests.rs

7 lines

identity_device_list_tests.rs

20 lines

identity_integration_tests.rs

7 lines

identity_keyserver_tests.rs

4 lines

identity_one_time_key_tests.rs

10 lines

identity_prekey_tests.rs

4 lines

identity_tunnelbroker_tests.rs

5 lines

shared/

grpc_clients/

src/

identity/

authenticated.rs

15 lines

mod.rs

1 line

shared.rs

2 lines

unauthenticated/

client.rs

16 lines

mod.rs

12 lines

Diff 40849

View Options

keyserver/addons/rust-node-addon/src/identity_client/mod.rs

View Options

native/native_rust_library/src/identity.rs

View Options

native/native_rust_library/src/identity/account_actions.rs

View Options

native/native_rust_library/src/identity/device_list.rs

View Options

native/native_rust_library/src/identity/exact_user_search.rs

View Options

native/native_rust_library/src/identity/farcaster.rs

View Options

native/native_rust_library/src/identity/find_user_identities.rs

View Options

native/native_rust_library/src/identity/login.rs

View Options

native/native_rust_library/src/identity/registration.rs

View Options

native/native_rust_library/src/identity/x3dh.rs

View Options

services/commtest/src/identity/device.rs

View Options

services/commtest/tests/identity_access_tokens_tests.rs

View Options

services/commtest/tests/identity_device_list_tests.rs

View Options

services/commtest/tests/identity_integration_tests.rs

View Options

services/commtest/tests/identity_keyserver_tests.rs

View Options

services/commtest/tests/identity_one_time_key_tests.rs

View Options

services/commtest/tests/identity_prekey_tests.rs

View Options

services/commtest/tests/identity_tunnelbroker_tests.rs

View Options

shared/grpc_clients/src/identity/authenticated.rs

View Options

shared/grpc_clients/src/identity/mod.rs

View Options

shared/grpc_clients/src/identity/shared.rs

View Options

shared/grpc_clients/src/identity/unauthenticated/client.rs

View Options

shared/grpc_clients/src/identity/unauthenticated/mod.rs

[grpc_clients] Accept PlatformMetadata when creating clientClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 40849

keyserver/addons/rust-node-addon/src/identity_client/mod.rs

native/native_rust_library/src/identity.rs

native/native_rust_library/src/identity/account_actions.rs

native/native_rust_library/src/identity/device_list.rs

native/native_rust_library/src/identity/exact_user_search.rs

native/native_rust_library/src/identity/farcaster.rs

native/native_rust_library/src/identity/find_user_identities.rs

native/native_rust_library/src/identity/login.rs

native/native_rust_library/src/identity/registration.rs

native/native_rust_library/src/identity/x3dh.rs

services/commtest/src/identity/device.rs

services/commtest/tests/identity_access_tokens_tests.rs

services/commtest/tests/identity_device_list_tests.rs

services/commtest/tests/identity_integration_tests.rs

services/commtest/tests/identity_keyserver_tests.rs

services/commtest/tests/identity_one_time_key_tests.rs

services/commtest/tests/identity_prekey_tests.rs

services/commtest/tests/identity_tunnelbroker_tests.rs

shared/grpc_clients/src/identity/authenticated.rs

shared/grpc_clients/src/identity/mod.rs

shared/grpc_clients/src/identity/shared.rs

shared/grpc_clients/src/identity/unauthenticated/client.rs

shared/grpc_clients/src/identity/unauthenticated/mod.rs

[grpc_clients] Accept PlatformMetadata when creating client
ClosedPublic
Actions

Revision Contents
Changeset List