Paths

Table of Contentst

-
services/terraform/self-host/
-
terraform/
-
self-host/
-
aws_db.tf

Differential D12322

[terraform] MariaDB RDS config options
ClosedPublic
Actions

Authored by will on Jun 5 2024, 3:22 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Apr 6, 12:54 PM

	Unknown Object (File)
	Wed, Apr 2, 1:42 PM

	Unknown Object (File)
	Sun, Mar 30, 9:17 PM

	Unknown Object (File)
	Wed, Mar 19, 3:57 AM

	Unknown Object (File)
	Fri, Mar 14, 3:06 AM

	Unknown Object (File)
	Tue, Mar 11, 12:00 PM

	Unknown Object (File)
	Mar 6 2025, 7:35 PM

	Unknown Object (File)
	Mar 5 2025, 1:58 AM

Subscribers

Details

Reviewers

ashoat
bartek
varun

Commits

rCOMMb2f66ef85324: [terraform] MariaDB RDS config options

Summary

This sets mostly the same parameter options as MariaDB besides innodb_buffer_pool_size which is set to {DBInstanceClassMemory*3/4} matching our phabricator database and general recommendations.

Here are the configuration options in our keyserver docker compose file:

--performance-schema
--max-allowed-packet=256M
--local-infile=0
--sql-mode=STRICT_ALL_TABLES
--innodb-buffer-pool-size=1600M
--innodb-ft-min-token-size=1
--innodb-ft-enable-stopword=0

Test Plan

successful terraform deploy. Ran transfer process and successfully accessed the rds instance with mysql

Diff Detail

Repository

Branch

keyserver_to_aws

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Jun 5 2024, 3:22 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 5 2024, 3:22 PM

will added inline comments.Jun 5 2024, 3:25 PM

services/terraform/self-host/aws_db.tf
60	This is representative of 256 MiB: (1024 * 1024 * 256).

will edited the test plan for this revision. (Show Details)Jun 5 2024, 3:27 PM

will edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B29463: Diff 40998.Jun 5 2024, 3:39 PM

will requested review of this revision.Jun 5 2024, 3:39 PM

will added a child revision: D12323: [terraform] remove usage of s3 bucket for terraform config.Jun 5 2024, 4:18 PM

I haven't dug deep into what these params mean but they match docker configuration so it should be okay

services/terraform/self-host/aws_db.tf
60	Comment would be good

This revision is now accepted and ready to land.Jun 6 2024, 12:34 AM

add comment: 256 MiB: (1024 * 1024 * 256)

Harbormaster completed remote builds in B29495: Diff 41068.Jun 6 2024, 12:00 PM

ashoat mentioned this in D12337: [keyserver] Bump MariaDB --innodb-buffer-pool-size config to 14000M in docker-compose.yml.Jun 6 2024, 8:02 PM

rebase

Harbormaster completed remote builds in B29506: Diff 41079.Jun 6 2024, 9:28 PM

ashoat mentioned this in rCOMMcdbbbc452d07: [keyserver] Bump MariaDB --innodb-buffer-pool-size config to 14000M in docker….Jun 7 2024, 5:55 AM

Closed by commit rCOMMb2f66ef85324: [terraform] MariaDB RDS config options (authored by will). · Explain WhyJun 7 2024, 10:55 AM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMMb2f66ef85324: [terraform] MariaDB RDS config options.

Revision Contents
Changeset List

Path

Size

services/

terraform/

self-host/

50 lines

Diff 40998

services/terraform/self-host/aws_db.tf

This file contains generated code, which does not normally need to be reviewed. Show File Contents