Page MenuHomePhabricator
Differential D12293

[lib] Inline `innerThreadFrozenDueToBlock` in `threadFrozenDueToBlock`
ClosedPublic
Actions

Authored by atul on Jun 3 2024, 1:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 30, 3:09 PM
Unknown Object (File)
Thu, Mar 6, 7:30 AM
Unknown Object (File)
Thu, Mar 6, 7:30 AM
Unknown Object (File)
Thu, Mar 6, 7:30 AM
Unknown Object (File)
Thu, Mar 6, 7:30 AM
Unknown Object (File)
Thu, Mar 6, 7:30 AM
Unknown Object (File)
Feb 23 2025, 11:35 AM
Unknown Object (File)
Jan 30 2025, 9:51 AM
View All 80 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
varun
Commits
rCOMM0050bc8a8abe: [lib] Inline `innerThreadFrozenDueToBlock` in `threadFrozenDueToBlock`
Summary

threadFrozenDueToBlock was last callsite of innerThreadFrozenDueToBlock, so inlining and removing innerThreadFrozenDueToBlock altogether.

Depends on D12292

Test Plan

flow + close reading

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D12293 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
shared/
13 lines

Diff 41362

View Options

lib/shared/thread-utils.js

Show First 20 Lines • Show All 98 Lines • ▼ Show 20 Lines
export type FFmpegStatistics = { export type FFmpegStatistics = {
// seconds of video being processed per second // seconds of video being processed per second
+speed: number, +speed: number,
// total milliseconds of video processed so far // total milliseconds of video processed so far
+time: number, +time: number,
// total result file size in bytes so far // total result file size in bytes so far
+size: number, +size: number,
+videoQuality: number,
+videoFrameNumber: number,
+videoFps: number,
+bitrate: number,
}; };
export type TranscodeVideoMediaMissionStep = { export type TranscodeVideoMediaMissionStep = {
+step: 'video_ffmpeg_transcode', +step: 'video_ffmpeg_transcode',
+success: boolean, +success: boolean,
+exceptionMessage: ?string, +exceptionMessage: ?string,
+time: number, // ms +time: number, // ms
+returnCode: ?number,
+newPath: ?string, +newPath: ?string,
+stats: ?FFmpegStatistics, +stats: ?FFmpegStatistics,
}; };
export type VideoGenerateThumbnailMediaMissionStep = { export type VideoGenerateThumbnailMediaMissionStep = {
+step: 'video_generate_thumbnail', +step: 'video_generate_thumbnail',
+success: boolean, +success: boolean,
+time: number, // ms +time: number, // ms
▲ Show 20 Lines • Show All 698 Lines • Show Last 20 Lines