Page MenuHomePhabricator
Differential D12293

[lib] Inline `innerThreadFrozenDueToBlock` in `threadFrozenDueToBlock`
ClosedPublic
Actions

Authored by atul on Jun 3 2024, 1:54 PM.
Tags
None
Referenced Files
F6241293: D12293.diff
Fri, Apr 25, 12:36 AM
Unknown Object (File)
Sun, Apr 20, 6:07 AM
Unknown Object (File)
Thu, Apr 17, 9:17 PM
Unknown Object (File)
Wed, Apr 16, 10:14 AM
Unknown Object (File)
Wed, Apr 16, 10:00 AM
Unknown Object (File)
Wed, Apr 16, 9:56 AM
Unknown Object (File)
Wed, Apr 16, 7:06 AM
Unknown Object (File)
Tue, Apr 15, 12:41 AM
View All 90 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
varun
Commits
rCOMM0050bc8a8abe: [lib] Inline `innerThreadFrozenDueToBlock` in `threadFrozenDueToBlock`
Summary

threadFrozenDueToBlock was last callsite of innerThreadFrozenDueToBlock, so inlining and removing innerThreadFrozenDueToBlock altogether.

Depends on D12292

Test Plan

flow + close reading

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D12293 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
shared/
13 lines

Diff 41362

View Options

lib/shared/thread-utils.js

// @flow // @flow
import { createUserKeysBackupActionTypes } from '../actions/backup-actions.js'; import { createUserKeysBackupActionTypes } from '../actions/backup-actions.js';
import { changeIdentityUserPasswordActionTypes } from '../actions/user-actions.js';
import type { BackupStore } from '../types/backup-types.js'; import type { BackupStore } from '../types/backup-types.js';
import type { BaseAction } from '../types/redux-types.js'; import type { BaseAction } from '../types/redux-types.js';
function reduceBackupStore( function reduceBackupStore(
store: BackupStore, store: BackupStore,
action: BaseAction, action: BaseAction,
): BackupStore { ): BackupStore {
if (action.type === createUserKeysBackupActionTypes.success) { if (action.type === createUserKeysBackupActionTypes.success) {
const latestBackupInfo = action.payload; const latestBackupInfo = action.payload;
return { return {
latestBackupInfo, latestBackupInfo,
}; };
} else if (action.type === changeIdentityUserPasswordActionTypes.success) {
return {
latestBackupInfo: null,
};
} }
return store; return store;
} }
export { reduceBackupStore }; export { reduceBackupStore };