[lib] Introduce `MemberInfoSansPermissions`
ClosedPublic
Actions

Authored by atul on Jun 4 2024, 2:29 PM.

Details

Reviewers

ashoat
ginsu
tomek
varun

Commits

rCOMM9cc32873ab68: [lib] Introduce `MemberInfoSansPermissions`

Summary

Introduce MemberInfoSansPermissions, stripPermissionsFromMemberInfo, and some unit tests.

The type will eventually replace MemberInfoWithPermissions in RawThreadInfo, but for now it's convenient to use to "surface" flow issues.

Depends on D12296

Test Plan

flow + unit tests

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D12315 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jun 4 2024, 2:29 PM

This is really mostly for my convenience so I can avoid stashing/unstashing while working through remainder of stack until ready to replace MemberInfoWithPermissions with MemberInfoSansPermissions.

atul published this revision for review.Jun 4 2024, 2:31 PM

Harbormaster completed remote builds in B29445: Diff 40974.Jun 4 2024, 2:46 PM

tomek accepted this revision.Jun 5 2024, 2:30 AM

tomek added inline comments.

lib/types/minimally-encoded-thread-permissions-types.js
108–113 ↗	(On Diff #40974)	How about using `$Diff`?

This revision is now accepted and ready to land.Jun 5 2024, 2:30 AM

tomek added inline comments.Jun 5 2024, 2:32 AM

lib/types/minimally-encoded-thread-permissions-types.js
108–113 ↗	(On Diff #40974)	Or even `$Rest` https://flow.org/en/docs/types/utilities/#toc-rest which is the type that represents the runtime object rest operation