Page MenuHomePhabricator
Differential D12506

[comm-lib] Implement FromRequest for AuthService
ClosedPublic
Actions

Authored by bartek on Jun 20 2024, 2:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 15, 4:11 AM
Unknown Object (File)
Wed, Nov 13, 8:08 PM
Unknown Object (File)
Fri, Nov 1, 2:26 PM
Unknown Object (File)
Sun, Oct 20, 2:40 PM
Unknown Object (File)
Oct 12 2024, 1:26 PM
Unknown Object (File)
Oct 12 2024, 1:26 PM
Unknown Object (File)
Oct 12 2024, 1:26 PM
Unknown Object (File)
Oct 12 2024, 1:26 PM
View All 33 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
varun
will
Commits
rCOMM8a4928e1ee25: [comm-lib] Implement FromRequest for AuthService
Summary

Extracted code that retrieves AuthService into a dedicated trait implementation.
Inspired by the web::Data counterpart.

Depends on D12504

Test Plan

Local backup and reports services. Commenting out .app_data(auth_service) from http/mod causes
the error message to be printed.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
services/
backup/
src/
http/
handlers/
8 lines
reports/
src/
http/
14 lines
shared/
comm-lib/
src/
http/
21 lines

Diff 41544

View Options

services/backup/src/http/handlers/backup.rs

Loading...
View Options

services/reports/src/http/service.rs

Loading...
View Options

shared/comm-lib/src/http/auth.rs

Loading...