Page MenuHomePhabricator
Differential D12527

[lib][web][native] add Tunnelbroker device token to redux
ClosedPublic
Actions

Authored by kamil on Jun 20 2024, 3:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 10:36 PM
Unknown Object (File)
Fri, Nov 8, 1:30 PM
Unknown Object (File)
Fri, Nov 8, 12:24 PM
Unknown Object (File)
Fri, Nov 8, 12:24 PM
Unknown Object (File)
Fri, Nov 8, 12:24 PM
Unknown Object (File)
Tue, Nov 5, 12:36 AM
Unknown Object (File)
Mon, Nov 4, 10:39 PM
Unknown Object (File)
Tue, Oct 22, 1:17 PM
View All 81 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
marcin
inka
Commits
rCOMM41d017de4cc6: [lib][web][native] add Tunnelbroker device token to redux
Summary

ENG-8400 and ENG-8348

Test Plan

Test migration

Diff Detail

Repository
rCOMM Comm
Branch
device-token
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jun 20 2024, 3:51 PM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 20 2024, 3:51 PM
kamil updated this revision to Diff 41585.Jun 20 2024, 3:55 PM

rename

Harbormaster completed remote builds in B29850: Diff 41585.Jun 20 2024, 4:10 PM
kamil published this revision for review.Jun 20 2024, 4:13 PM
Harbormaster failed remote builds in B29849: Diff 41584!Jun 20 2024, 4:16 PM
inka added inline comments.Jun 21 2024, 12:33 AM
lib/reducers/tunnelbroker-device-token-reducer.js
7–12 ↗(On Diff #41585)

I'm guessing this will be updated?

native/redux/persist.js
1424 ↗(On Diff #41585)

Don't we want to update this?

web/redux/persist.js
571 ↗(On Diff #41585)

Shouldn't we update storeVersion?

kamil updated this revision to Diff 41597.Jun 21 2024, 1:20 AM

bump version

lib/reducers/tunnelbroker-device-token-reducer.js
7–12 ↗(On Diff #41585)

sure, in next diffs

native/redux/persist.js
1424 ↗(On Diff #41585)

yeah we want, forgot to commit that change, thanks for catching

Harbormaster completed remote builds in B29862: Diff 41597.Jun 21 2024, 1:36 AM
kamil added a child revision: D12536: [lib][web][native] set local Tunnelbroker device token on client.Jun 21 2024, 2:19 AM
inka accepted this revision.Jun 21 2024, 2:35 AM
This revision is now accepted and ready to land.Jun 21 2024, 2:35 AM
kamil updated this revision to Diff 41807.Jun 28 2024, 7:02 AM

rebase

Harbormaster completed remote builds in B29999: Diff 41807.Jun 28 2024, 7:19 AM
Closed by commit rCOMM41d017de4cc6: [lib][web][native] add Tunnelbroker device token to redux (authored by kamil). · Explain WhyJun 28 2024, 7:28 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM41d017de4cc6: [lib][web][native] add Tunnelbroker device token to redux.

Revision Contents
Changeset List

Diff 41597

View Options

lib/reducers/master-reducer.js

Loading...
View Options

lib/reducers/tunnelbroker-device-token-reducer.js

Loading...
View Options

lib/types/redux-types.js

Loading...
View Options

lib/types/tunnelbroker-device-token-types.js

Loading...
View Options

lib/utils/reducers-utils.test.js

Loading...
View Options

native/redux/default-state.js

Loading...
View Options

native/redux/persist.js

Loading...
View Options

native/redux/state-types.js

Loading...
View Options

web/redux/default-state.js

Loading...
View Options

web/redux/handle-redux-migration-failure.js

Loading...
View Options

web/redux/persist-constants.js

Loading...
View Options

web/redux/persist.js

Loading...
View Options

web/redux/redux-setup.js

Loading...