[lib] DMOperationSpec for SEND_TEXT_MESSAGE operation
ClosedPublic
Actions

Authored by ashoat on Jul 3 2024, 7:51 PM.

Details

Reviewers

tomek
marcin
inka

Commits

rCOMM23cf032f052c: [lib] DMOperationSpec for SEND_TEXT_MESSAGE operation

Summary

I did this one first because it's more simple

Depends on D12652

Test Plan

I haven't tested this stack outside of Flow. I'd like to propose that we land this so the team can iterate. I'll make sure to test all of the functionality once it's integrated into the rest of the codebase.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Jul 3 2024, 7:51 PM

ashoat added a child revision: D12656: [lib] Make it possible to skip some thread/message properties.

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 3 2024, 8:05 PM

Harbormaster failed remote builds in B30105: Diff 41976!

Rebase

Harbormaster completed remote builds in B30111: Diff 41982.Jul 3 2024, 8:29 PM

ashoat requested review of this revision.Jul 3 2024, 8:29 PM

inka added inline comments.Jul 4 2024, 6:07 AM

lib/shared/dm-ops/send-text-message-spec.js
27	Why do we use this id?

ashoat added inline comments.Jul 4 2024, 6:44 AM

lib/shared/dm-ops/send-text-message-spec.js
27	Sorry, forgot to explain this. These `id`s are only used for `UpdateInfo`s on the keyserver side... they don't matter at all on the client side. At some point we probably should have changed the types to remove them, and I suppose we should still do that now... but it's tough to prioritize it given our launch schedule Created ENG-8713 as a follow-up

Thank you for explaining

This revision is now accepted and ready to land.Jul 4 2024, 7:01 AM

Decided to use a UUID instead of 'ignored'. I'm pretty sure it's not used on the client anywhere, but figured it's better to avoid any risks in case it affects anything, given our tight timeline for launch

This revision was landed with ongoing or failed builds.Jul 4 2024, 11:15 AM

Closed by commit rCOMM23cf032f052c: [lib] DMOperationSpec for SEND_TEXT_MESSAGE operation (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM23cf032f052c: [lib] DMOperationSpec for SEND_TEXT_MESSAGE operation.

Harbormaster completed remote builds in B30164: Diff 42056.Jul 4 2024, 11:52 AM

tomek added inline comments.Jul 19 2024, 12:50 PM