Page MenuHomePhabricator
Differential D12710

[terraform] add authoritative keyserver id as a user-specified variable
ClosedPublic
Actions

Authored by will on Jul 9 2024, 7:28 PM.
Tags
None
Referenced Files
F3181421: D12710.id42372.diff
Fri, Nov 8, 6:17 AM
F3181260: D12710.id42419.diff
Fri, Nov 8, 5:59 AM
Unknown Object (File)
Fri, Oct 11, 7:22 PM
Unknown Object (File)
Fri, Oct 11, 7:05 PM
Unknown Object (File)
Fri, Oct 11, 7:02 PM
Unknown Object (File)
Sep 25 2024, 7:55 PM
Unknown Object (File)
Sep 25 2024, 7:54 PM
Unknown Object (File)
Sep 25 2024, 7:54 PM
View All 63 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
Commits
rCOMMd08760937f81: [terraform] add authoritative keyserver id as a user-specified variable
Summary

Introduce specifying the authoritative keyserver id as a terraform variable which translates to a keyserver environmental variable

Depends on D12709

Test Plan

In our prior testing, wasn't able to connect a debug native client without specifying the authoritative id to the keyserver.
With this configuration, was able to connect properly. Previously set this manually

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Jul 9 2024, 7:28 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 9 2024, 7:28 PM
will added a child revision: D12711: [terraform] Introduce secondary keyserver service.Jul 9 2024, 7:32 PM
Harbormaster completed remote builds in B30251: Diff 42190.Jul 9 2024, 7:45 PM
will requested review of this revision.Jul 9 2024, 7:45 PM
ashoat added inline comments.Jul 10 2024, 10:24 AM
services/terraform/self-host/variables.tf
40–41

Should we rename this something like authoritative_keyserver_user_id for clarity? At the least, it would be helpful to clarify in the description that it's a user ID

will planned changes to this revision.Jul 11 2024, 12:32 PM
will added inline comments.
services/terraform/self-host/variables.tf
40–41

Yeah. I think that'd be helpful to the user. I'll also update the description as well

Including in next rebase

will updated this revision to Diff 42372.Jul 16 2024, 7:54 PM

review feedback

Harbormaster completed remote builds in B30401: Diff 42372.Jul 16 2024, 8:11 PM
bartek accepted this revision.Jul 17 2024, 12:45 AM
This revision is now accepted and ready to land.Jul 17 2024, 12:45 AM
will updated this revision to Diff 42419.Jul 17 2024, 3:04 PM

make authoritative id variable a config json object

Harbormaster completed remote builds in B30443: Diff 42419.Jul 17 2024, 3:21 PM
Closed by commit rCOMMd08760937f81: [terraform] add authoritative keyserver id as a user-specified variable (authored by will). · Explain WhyJul 17 2024, 7:01 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMMd08760937f81: [terraform] add authoritative keyserver id as a user-specified variable.

Revision Contents
Changeset List

PathSize
services/
terraform/
self-host/
6 lines
5 lines

Diff 42190

View Options

services/terraform/self-host/keyserver_primary.tf

Loading...
View Options

services/terraform/self-host/variables.tf

Loading...