Page MenuHomePhabricator
Differential D12619

[keyserver] display copyable url for qr code auth
ClosedPublic
Actions

Authored by varun on Jun 28 2024, 12:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 26, 3:47 PM
Unknown Object (File)
Fri, Nov 22, 11:10 PM
Unknown Object (File)
Fri, Nov 22, 7:15 PM
Unknown Object (File)
Tue, Nov 12, 12:31 PM
Unknown Object (File)
Tue, Nov 12, 9:42 AM
Unknown Object (File)
Tue, Nov 12, 9:14 AM
Unknown Object (File)
Tue, Nov 12, 4:01 AM
Unknown Object (File)
Oct 15 2024, 11:20 PM
View All 51 Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMM816b07e456a8: [keyserver] display copyable url for qr code auth
Summary

if a user is on a simulator or emulator they can't just scan the QR code, so we display the URL that's embedded in the QR Code so it can be copied

Depends on D12618

Test Plan

Confirmed that the URL displayed in my terminal above the QR Code

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Jun 28 2024, 12:56 PM
Herald added a subscriber: tomek. · View Herald TranscriptJun 28 2024, 12:56 PM
varun added a child revision: D12620: [native] modify SecondaryDeviceQRCodeScanner to support emulator.Jun 28 2024, 12:58 PM
Harbormaster completed remote builds in B30006: Diff 41820.Jun 28 2024, 1:12 PM
varun requested review of this revision.Jun 28 2024, 1:12 PM
ashoat accepted this revision.Jul 1 2024, 4:14 PM
This revision is now accepted and ready to land.Jul 1 2024, 4:14 PM
ashoat added a comment.Jul 1 2024, 4:14 PM

What is the URL that is printed? Wondering if it's https or some sort of deep link

varun added a comment.Jul 11 2024, 12:02 PM
In D12619#357437, @ashoat wrote:

What is the URL that is printed? Wondering if it's https or some sort of deep link

it's not https. it looks like this:

[NODEM] Open the Comm app on your phone and scan the QR code below, or copy and paste this URL:
[NODEM] 
[NODEM] comm://qr-code/%7B%22aes256%22%3A%229c1541b9971c48735750834d2a882f189d37936c239e24e53d6f74f02d730e77%22%2C%22ed25519%22%3A%22jGD0dpmjPp7ytWBY7JwssT3rQJlTOlVWa7ViUq219x4%22%7D
Closed by commit rCOMM816b07e456a8: [keyserver] display copyable url for qr code auth (authored by varun). · Explain WhyJul 12 2024, 12:18 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM816b07e456a8: [keyserver] display copyable url for qr code auth.

Revision Contents
Changeset List

PathSize
keyserver/
src/
5 lines

Diff 42252

View Options

keyserver/src/keyserver.js

Loading...