Page MenuHomePhabricator

[terraform] add authoritative keyserver id as a user-specified variable
ClosedPublic

Authored by will on Jul 9 2024, 7:28 PM.
Tags
None
Referenced Files
F3181421: D12710.id42372.diff
Fri, Nov 8, 6:17 AM
F3181260: D12710.id42419.diff
Fri, Nov 8, 5:59 AM
Unknown Object (File)
Fri, Oct 11, 7:22 PM
Unknown Object (File)
Fri, Oct 11, 7:05 PM
Unknown Object (File)
Fri, Oct 11, 7:02 PM
Unknown Object (File)
Sep 25 2024, 7:55 PM
Unknown Object (File)
Sep 25 2024, 7:54 PM
Unknown Object (File)
Sep 25 2024, 7:54 PM
Subscribers

Details

Summary

Introduce specifying the authoritative keyserver id as a terraform variable which translates to a keyserver environmental variable

Depends on D12709

Test Plan

In our prior testing, wasn't able to connect a debug native client without specifying the authoritative id to the keyserver.
With this configuration, was able to connect properly. Previously set this manually

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will requested review of this revision.Jul 9 2024, 7:45 PM
services/terraform/self-host/variables.tf
40–41 ↗(On Diff #42190)

Should we rename this something like authoritative_keyserver_user_id for clarity? At the least, it would be helpful to clarify in the description that it's a user ID

will added inline comments.
services/terraform/self-host/variables.tf
40–41 ↗(On Diff #42190)

Yeah. I think that'd be helpful to the user. I'll also update the description as well

Including in next rebase

This revision is now accepted and ready to land.Jul 17 2024, 12:45 AM

make authoritative id variable a config json object