issue: ENG-8891
Details
Tested that in a newly created db the target_message is filled in for sidebar source, by searching in a sidebar and getting a result for the first message of that siedbar
Tested that the migration succeeds and after it is run it is also possible to search for the first message in a sidebar
Diff Detail
- Repository
- rCOMM Comm
- Branch
- inka/search
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp | ||
---|---|---|
227 | Can we use MessageType::SIDEBAR_SOURCE? By the way, MessageType should use explicit value expressions. |
Use MessageType::SIDEBAR_SOURCE, update MessageType. Had to move MessageType to avoid importing folly on web
Requesting review because I am not familiar with cpp and a lot of decisions had to be made
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp | ||
---|---|---|
817 ↗ | (On Diff #42814) | My ide formats is like this |
Thanks for doing the MessageType extraction! I put up a diff for this (D12761) but ended up abandoning it... probably should have just left it there.
native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/MessageOperationsUtilities/MessageTypeEnum.h | ||
---|---|---|
1–28 ↗ | (On Diff #42830) | This file is rather messy.
|