Page MenuHomePhabricator
Differential D12869

[native][web] Fill target_message column for sidebar source
ClosedPublic
Actions

Authored by inka on Jul 24 2024, 7:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 12:02 PM
Unknown Object (File)
Thu, Oct 17, 11:17 PM
Unknown Object (File)
Mon, Oct 14, 9:57 PM
Unknown Object (File)
Mon, Oct 14, 4:43 PM
Unknown Object (File)
Mon, Oct 14, 4:42 PM
Unknown Object (File)
Mon, Oct 14, 4:42 PM
Unknown Object (File)
Thu, Oct 10, 6:50 AM
Unknown Object (File)
Thu, Oct 10, 6:50 AM
View All 35 Files
Subscribers
ashoat

Details

Reviewers
tomek
kamil
marcin
Commits
rCOMM093bb2f18a91: [native][web] Fill target_message column for sidebar source
Summary

issue: ENG-8891

Test Plan

Tested that in a newly created db the target_message is filled in for sidebar source, by searching in a sidebar and getting a result for the first message of that siedbar
Tested that the migration succeeds and after it is run it is also possible to search for the first message in a sidebar

Diff Detail

Repository
rCOMM Comm
Branch
inka/search
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Jul 24 2024, 7:51 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJul 24 2024, 7:51 AM
inka added a parent revision: D12867: [native][web] Fetch related messages for search.Jul 24 2024, 7:51 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 24 2024, 7:54 AM
Harbormaster failed remote builds in B30641: Diff 42737!
inka updated this revision to Diff 42761.Jul 25 2024, 1:01 AM

Rebase

Harbormaster completed remote builds in B30661: Diff 42761.Jul 25 2024, 1:18 AM
inka requested review of this revision.Jul 25 2024, 1:18 AM
inka updated this revision to Diff 42771.Jul 25 2024, 5:03 AM

Rebase

Harbormaster completed remote builds in B30667: Diff 42771.Jul 25 2024, 5:23 AM
tomek accepted this revision.Jul 25 2024, 6:23 AM
tomek added inline comments.
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
227 ↗(On Diff #42771)

Can we use MessageType::SIDEBAR_SOURCE? By the way, MessageType should use explicit value expressions.

This revision is now accepted and ready to land.Jul 25 2024, 6:23 AM
inka updated this revision to Diff 42809.Jul 26 2024, 3:09 AM

Use MessageType::SIDEBAR_SOURCE, update MessageType. Had to move MessageType to avoid importing folly on web

inka requested review of this revision.Jul 26 2024, 3:10 AM

Requesting review because I am not familiar with cpp and a lot of decisions had to be made

inka updated this revision to Diff 42810.Jul 26 2024, 3:11 AM

Add newline

inka updated this revision to Diff 42811.Jul 26 2024, 3:23 AM

Rename

Harbormaster failed remote builds in B30693: Diff 42809!Jul 26 2024, 3:31 AM
inka updated this revision to Diff 42813.Jul 26 2024, 3:33 AM

Change case

inka updated this revision to Diff 42814.Jul 26 2024, 3:36 AM

Fix case

inka added inline comments.Jul 26 2024, 3:37 AM
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
817 ↗(On Diff #42814)

My ide formats is like this

Harbormaster failed remote builds in B30694: Diff 42810!Jul 26 2024, 3:38 AM
tomek accepted this revision.Jul 26 2024, 3:39 AM
This revision is now accepted and ready to land.Jul 26 2024, 3:39 AM
Harbormaster completed remote builds in B30695: Diff 42811.Jul 26 2024, 3:46 AM
Harbormaster completed remote builds in B30697: Diff 42813.Jul 26 2024, 3:58 AM
Harbormaster completed remote builds in B30698: Diff 42814.Jul 26 2024, 4:06 AM
Closed by commit rCOMM093bb2f18a91: [native][web] Fill target_message column for sidebar source (authored by inka). · Explain WhyJul 26 2024, 5:28 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM093bb2f18a91: [native][web] Fill target_message column for sidebar source.
ashoat added a comment.Jul 31 2024, 7:18 PM

Thanks for doing the MessageType extraction! I put up a diff for this (D12761) but ended up abandoning it... probably should have just left it there.

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/MessageOperationsUtilities/MessageTypeEnum.h
1–28 ↗(On Diff #42830)

This file is rather messy.

  1. Can you add #pragma once to the top?
  2. Can you add line breaks before and after the namespace?
  3. Remove trailing line break
inka mentioned this in D12966: Fix .h file formatting.Aug 5 2024, 2:17 AM
inka added inline comments.Aug 5 2024, 2:17 AM
native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/MessageOperationsUtilities/MessageTypeEnum.h
1–28 ↗(On Diff #42830)

Created D12966 to address

inka mentioned this in rCOMM269a31c7bb56: Fix .h file formatting.Aug 5 2024, 7:26 AM

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
69 lines
NativeModules/
PersistentStorageUtilities/
MessageOperationsUtilities/
27 lines
28 lines
web/
shared-worker/
_generated/

Diff 42809

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/MessageOperationsUtilities/MessageSpecs.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/MessageOperationsUtilities/MessageTypeEnum.h

Loading...
View Options

web/shared-worker/_generated/comm_query_executor.wasm

Loading...