Page MenuHomePhabricator
Differential D13028

[SQLite] implement resetting Outbound P2P messages
ClosedPublic
Actions

Authored by kamil on Aug 8 2024, 4:23 AM.
Tags
None
Referenced Files
F3389414: D13028.id43328.diff
Fri, Nov 29, 7:00 PM
F3388611: D13028.diff
Fri, Nov 29, 3:09 PM
Unknown Object (File)
Wed, Nov 20, 3:10 AM
Unknown Object (File)
Wed, Nov 20, 3:09 AM
Unknown Object (File)
Wed, Nov 20, 2:44 AM
Unknown Object (File)
Sat, Nov 9, 10:12 AM
Unknown Object (File)
Oct 14 2024, 7:19 PM
Unknown Object (File)
Oct 14 2024, 7:19 PM
View All 34 Files
Subscribers
ashoat

Details

Reviewers
tomek
Commits
rCOMMdacfe284e5b0: [SQLite] implement resetting Outbound P2P messages
Summary

ENG-6982.

It is possible to do it as one query but will be more complicated and less readable, I can update if reviewers think it worth it.

Each query is described in code comments.

Test Plan

Tests

Diff Detail

Repository
rCOMM Comm
Branch
resending-2
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Aug 8 2024, 4:23 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptAug 8 2024, 4:23 AM
kamil added a child revision: D13029: [web] introduce resetting Outbound P2P Messages to shared worker.Aug 8 2024, 4:25 AM
Harbormaster failed remote builds in B31007: Diff 43256!Aug 8 2024, 4:46 AM
kamil published this revision for review.Aug 8 2024, 5:06 AM
tomek accepted this revision.Aug 12 2024, 1:11 AM
tomek added inline comments.
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2580–2611

What happens if one of them succeeds and one fails?

This revision is now accepted and ready to land.Aug 12 2024, 1:11 AM
kamil added inline comments.Aug 13 2024, 3:26 AM
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2580–2611

good call, I am going to wrap this in transaction in the following diffs

Harbormaster completed remote builds in B31007: Diff 43256.Aug 13 2024, 3:43 AM
Closed by commit rCOMMdacfe284e5b0: [SQLite] implement resetting Outbound P2P messages (authored by kamil). · Explain WhyAug 13 2024, 4:10 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMdacfe284e5b0: [SQLite] implement resetting Outbound P2P messages.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
2 lines
2 lines
78 lines
web/
cpp/
3 lines
shared-worker/
_generated/
queries/
82 lines
types/
1 line

Diff 43256

View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...
View Options

web/cpp/SQLiteQueryExecutorBindings.cpp

Loading...
View Options

web/shared-worker/_generated/comm_query_executor.wasm

Loading...
View Options

web/shared-worker/queries/outbound-p2p-message-queries.test.js

Loading...
View Options

web/shared-worker/types/sqlite-query-executor.js

Loading...