Page MenuHomePhabricator
Differential D13140

[web] Create a function that fetches messages in batches
ClosedPublic
Actions

Authored by tomek on Aug 22 2024, 10:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 21, 9:24 PM
Unknown Object (File)
Fri, Apr 18, 6:33 AM
Unknown Object (File)
Thu, Apr 17, 9:10 PM
Unknown Object (File)
Wed, Apr 16, 9:19 PM
Unknown Object (File)
Mon, Apr 7, 5:23 AM
Unknown Object (File)
Sun, Apr 6, 9:32 AM
Unknown Object (File)
Mar 8 2025, 5:10 PM
Unknown Object (File)
Mar 8 2025, 5:10 PM
View All 51 Files
Subscribers
ashoat

Details

Reviewers
kamil
inka
Commits
rCOMM1cee5c5f3b22: [web] Create a function that fetches messages in batches
Summary

The function uses limit and offset to get a batch of messages.

https://linear.app/comm/issue/ENG-8705/create-a-function-that-fetches-more-messages-and-dispatches-the-new

Depends on D13138

Test Plan

Tests.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Aug 22 2024, 10:19 AM
Herald added a subscriber: ashoat. · View Herald TranscriptAug 22 2024, 10:19 AM
Harbormaster completed remote builds in B31220: Diff 43591.Aug 22 2024, 10:37 AM
tomek requested review of this revision.Aug 22 2024, 10:37 AM
tomek added a child revision: D13141: [native] Expose messages fetching function through JSI.Aug 22 2024, 10:40 AM
tomek updated this revision to Diff 43619.EditedAug 23 2024, 9:09 AM

Extract thick thread types

Harbormaster completed remote builds in B31246: Diff 43619.Aug 23 2024, 9:26 AM
tomek updated this revision to Diff 43622.Aug 23 2024, 9:26 AM

Rebase

Harbormaster completed remote builds in B31249: Diff 43622.Aug 23 2024, 9:43 AM
kamil accepted this revision.Aug 26 2024, 2:43 AM
kamil added inline comments.
native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h
197–198 ↗(On Diff #43622)

This started to be annoying, thinking how long it could take to prioritize ENG-5719 after D12736 is landed

web/shared-worker/queries/fetch-messages-queries.test.js
36 ↗(On Diff #43622)

I would move 124 to const

This revision is now accepted and ready to land.Aug 26 2024, 2:43 AM
tomek updated this revision to Diff 43670.Aug 27 2024, 4:40 AM

Extract a constant

Harbormaster completed remote builds in B31278: Diff 43670.Aug 27 2024, 4:57 AM
Closed by commit rCOMM1cee5c5f3b22: [web] Create a function that fetches messages in batches (authored by tomek). · Explain WhyAug 27 2024, 8:02 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM1cee5c5f3b22: [web] Create a function that fetches messages in batches.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
4 lines
4 lines
33 lines
web/
cpp/
3 lines
shared-worker/
_generated/
queries/
109 lines
types/
1 line
7 lines

Diff 43670

View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Show First 20 Lines • Show All 57 Lines • ▼ Show 20 Linespublic:
std::unique_ptr<Thread> getThread(std::string threadID) const override; std::unique_ptr<Thread> getThread(std::string threadID) const override;
std::string getDraft(std::string key) const override; std::string getDraft(std::string key) const override;
void updateDraft(std::string key, std::string text) const override; void updateDraft(std::string key, std::string text) const override;
bool moveDraft(std::string oldKey, std::string newKey) const override; bool moveDraft(std::string oldKey, std::string newKey) const override;
std::vector<Draft> getAllDrafts() const override; std::vector<Draft> getAllDrafts() const override;
void removeAllDrafts() const override; void removeAllDrafts() const override;
void removeDrafts(const std::vector<std::string> &ids) const override; void removeDrafts(const std::vector<std::string> &ids) const override;
void removeAllMessages() const override; void removeAllMessages() const override;
std::vector<MessageEntity> getAllMessages() const override; std::vector<MessageEntity> getInitialMessages() const override;
void removeMessages(const std::vector<std::string> &ids) const override; void removeMessages(const std::vector<std::string> &ids) const override;
void removeMessagesForThreads( void removeMessagesForThreads(
const std::vector<std::string> &threadIDs) const override; const std::vector<std::string> &threadIDs) const override;
void replaceMessage(const Message &message) const override; void replaceMessage(const Message &message) const override;
void rekeyMessage(std::string from, std::string to) const override; void rekeyMessage(std::string from, std::string to) const override;
void replaceMessageStoreThreads( void replaceMessageStoreThreads(
const std::vector<MessageStoreThread> &threads) const override; const std::vector<MessageStoreThread> &threads) const override;
void void
▲ Show 20 Lines • Show All 123 Lines • ▼ Show 20 Lines std::vector<MessageEntity> searchMessages(
std::optional<std::string> timestampCursor, std::optional<std::string> timestampCursor,
std::optional<std::string> messageIDCursor) const override; std::optional<std::string> messageIDCursor) const override;
std::vector<MessageEntity> getRelatedMessagesForSearch( std::vector<MessageEntity> getRelatedMessagesForSearch(
const std::vector<std::string> &messageIDs) const override; const std::vector<std::string> &messageIDs) const override;
#ifdef EMSCRIPTEN #ifdef EMSCRIPTEN
std::vector<WebThread> getAllThreadsWeb() const override; std::vector<WebThread> getAllThreadsWeb() const override;
void replaceThreadWeb(const WebThread &thread) const override; void replaceThreadWeb(const WebThread &thread) const override;
std::vector<MessageWithMedias> getAllMessagesWeb() const override; std::vector<MessageWithMedias> getInitialMessagesWeb() const override;
void replaceMessageWeb(const WebMessage &message) const override; void replaceMessageWeb(const WebMessage &message) const override;
NullableString getOlmPersistAccountDataWeb(int accountID) const override; NullableString getOlmPersistAccountDataWeb(int accountID) const override;
std::vector<MessageWithMedias> std::vector<MessageWithMedias>
getRelatedMessagesWeb(const std::string &messageID) const override; getRelatedMessagesWeb(const std::string &messageID) const override;
std::vector<MessageWithMedias> searchMessagesWeb( std::vector<MessageWithMedias> searchMessagesWeb(
std::string query, std::string query,
std::string threadID, std::string threadID,
std::optional<std::string> timestampCursor, std::optional<std::string> timestampCursor,
Show All 10 Lines
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Show First 20 Lines • Show All 57 Lines • ▼ Show 20 Linespublic:
std::unique_ptr<Thread> getThread(std::string threadID) const override; std::unique_ptr<Thread> getThread(std::string threadID) const override;
std::string getDraft(std::string key) const override; std::string getDraft(std::string key) const override;
void updateDraft(std::string key, std::string text) const override; void updateDraft(std::string key, std::string text) const override;
bool moveDraft(std::string oldKey, std::string newKey) const override; bool moveDraft(std::string oldKey, std::string newKey) const override;
std::vector<Draft> getAllDrafts() const override; std::vector<Draft> getAllDrafts() const override;
void removeAllDrafts() const override; void removeAllDrafts() const override;
void removeDrafts(const std::vector<std::string> &ids) const override; void removeDrafts(const std::vector<std::string> &ids) const override;
void removeAllMessages() const override; void removeAllMessages() const override;
std::vector<MessageEntity> getAllMessages() const override; std::vector<MessageEntity> getInitialMessages() const override;
void removeMessages(const std::vector<std::string> &ids) const override; void removeMessages(const std::vector<std::string> &ids) const override;
void removeMessagesForThreads( void removeMessagesForThreads(
const std::vector<std::string> &threadIDs) const override; const std::vector<std::string> &threadIDs) const override;
void replaceMessage(const Message &message) const override; void replaceMessage(const Message &message) const override;
void rekeyMessage(std::string from, std::string to) const override; void rekeyMessage(std::string from, std::string to) const override;
void replaceMessageStoreThreads( void replaceMessageStoreThreads(
const std::vector<MessageStoreThread> &threads) const override; const std::vector<MessageStoreThread> &threads) const override;
void void
▲ Show 20 Lines • Show All 123 Lines • ▼ Show 20 Lines std::vector<MessageEntity> searchMessages(
std::optional<std::string> timestampCursor, std::optional<std::string> timestampCursor,
std::optional<std::string> messageIDCursor) const override; std::optional<std::string> messageIDCursor) const override;
std::vector<MessageEntity> getRelatedMessagesForSearch( std::vector<MessageEntity> getRelatedMessagesForSearch(
const std::vector<std::string> &messageIDs) const override; const std::vector<std::string> &messageIDs) const override;
#ifdef EMSCRIPTEN #ifdef EMSCRIPTEN
std::vector<WebThread> getAllThreadsWeb() const override; std::vector<WebThread> getAllThreadsWeb() const override;
void replaceThreadWeb(const WebThread &thread) const override; void replaceThreadWeb(const WebThread &thread) const override;
std::vector<MessageWithMedias> getAllMessagesWeb() const override; std::vector<MessageWithMedias> getInitialMessagesWeb() const override;
void replaceMessageWeb(const WebMessage &message) const override; void replaceMessageWeb(const WebMessage &message) const override;
NullableString getOlmPersistAccountDataWeb(int accountID) const override; NullableString getOlmPersistAccountDataWeb(int accountID) const override;
std::vector<MessageWithMedias> std::vector<MessageWithMedias>
getRelatedMessagesWeb(const std::string &messageID) const override; getRelatedMessagesWeb(const std::string &messageID) const override;
std::vector<MessageWithMedias> searchMessagesWeb( std::vector<MessageWithMedias> searchMessagesWeb(
std::string query, std::string query,
std::string threadID, std::string threadID,
std::optional<std::string> timestampCursor, std::optional<std::string> timestampCursor,
Show All 10 Lines
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Show First 20 Lines • Show All 57 Lines • ▼ Show 20 Linespublic:
std::unique_ptr<Thread> getThread(std::string threadID) const override; std::unique_ptr<Thread> getThread(std::string threadID) const override;
std::string getDraft(std::string key) const override; std::string getDraft(std::string key) const override;
void updateDraft(std::string key, std::string text) const override; void updateDraft(std::string key, std::string text) const override;
bool moveDraft(std::string oldKey, std::string newKey) const override; bool moveDraft(std::string oldKey, std::string newKey) const override;
std::vector<Draft> getAllDrafts() const override; std::vector<Draft> getAllDrafts() const override;
void removeAllDrafts() const override; void removeAllDrafts() const override;
void removeDrafts(const std::vector<std::string> &ids) const override; void removeDrafts(const std::vector<std::string> &ids) const override;
void removeAllMessages() const override; void removeAllMessages() const override;
std::vector<MessageEntity> getAllMessages() const override; std::vector<MessageEntity> getInitialMessages() const override;
void removeMessages(const std::vector<std::string> &ids) const override; void removeMessages(const std::vector<std::string> &ids) const override;
void removeMessagesForThreads( void removeMessagesForThreads(
const std::vector<std::string> &threadIDs) const override; const std::vector<std::string> &threadIDs) const override;
void replaceMessage(const Message &message) const override; void replaceMessage(const Message &message) const override;
void rekeyMessage(std::string from, std::string to) const override; void rekeyMessage(std::string from, std::string to) const override;
void replaceMessageStoreThreads( void replaceMessageStoreThreads(
const std::vector<MessageStoreThread> &threads) const override; const std::vector<MessageStoreThread> &threads) const override;
void void
▲ Show 20 Lines • Show All 123 Lines • ▼ Show 20 Lines std::vector<MessageEntity> searchMessages(
std::optional<std::string> timestampCursor, std::optional<std::string> timestampCursor,
std::optional<std::string> messageIDCursor) const override; std::optional<std::string> messageIDCursor) const override;
std::vector<MessageEntity> getRelatedMessagesForSearch( std::vector<MessageEntity> getRelatedMessagesForSearch(
const std::vector<std::string> &messageIDs) const override; const std::vector<std::string> &messageIDs) const override;
#ifdef EMSCRIPTEN #ifdef EMSCRIPTEN
std::vector<WebThread> getAllThreadsWeb() const override; std::vector<WebThread> getAllThreadsWeb() const override;
void replaceThreadWeb(const WebThread &thread) const override; void replaceThreadWeb(const WebThread &thread) const override;
std::vector<MessageWithMedias> getAllMessagesWeb() const override; std::vector<MessageWithMedias> getInitialMessagesWeb() const override;
void replaceMessageWeb(const WebMessage &message) const override; void replaceMessageWeb(const WebMessage &message) const override;
NullableString getOlmPersistAccountDataWeb(int accountID) const override; NullableString getOlmPersistAccountDataWeb(int accountID) const override;
std::vector<MessageWithMedias> std::vector<MessageWithMedias>
getRelatedMessagesWeb(const std::string &messageID) const override; getRelatedMessagesWeb(const std::string &messageID) const override;
std::vector<MessageWithMedias> searchMessagesWeb( std::vector<MessageWithMedias> searchMessagesWeb(
std::string query, std::string query,
std::string threadID, std::string threadID,
std::optional<std::string> timestampCursor, std::optional<std::string> timestampCursor,
Show All 10 Lines
View Options

web/cpp/SQLiteQueryExecutorBindings.cpp

Show First 20 Lines • Show All 57 Lines • ▼ Show 20 Linespublic:
std::unique_ptr<Thread> getThread(std::string threadID) const override; std::unique_ptr<Thread> getThread(std::string threadID) const override;
std::string getDraft(std::string key) const override; std::string getDraft(std::string key) const override;
void updateDraft(std::string key, std::string text) const override; void updateDraft(std::string key, std::string text) const override;
bool moveDraft(std::string oldKey, std::string newKey) const override; bool moveDraft(std::string oldKey, std::string newKey) const override;
std::vector<Draft> getAllDrafts() const override; std::vector<Draft> getAllDrafts() const override;
void removeAllDrafts() const override; void removeAllDrafts() const override;
void removeDrafts(const std::vector<std::string> &ids) const override; void removeDrafts(const std::vector<std::string> &ids) const override;
void removeAllMessages() const override; void removeAllMessages() const override;
std::vector<MessageEntity> getAllMessages() const override; std::vector<MessageEntity> getInitialMessages() const override;
void removeMessages(const std::vector<std::string> &ids) const override; void removeMessages(const std::vector<std::string> &ids) const override;
void removeMessagesForThreads( void removeMessagesForThreads(
const std::vector<std::string> &threadIDs) const override; const std::vector<std::string> &threadIDs) const override;
void replaceMessage(const Message &message) const override; void replaceMessage(const Message &message) const override;
void rekeyMessage(std::string from, std::string to) const override; void rekeyMessage(std::string from, std::string to) const override;
void replaceMessageStoreThreads( void replaceMessageStoreThreads(
const std::vector<MessageStoreThread> &threads) const override; const std::vector<MessageStoreThread> &threads) const override;
void void
▲ Show 20 Lines • Show All 123 Lines • ▼ Show 20 Lines std::vector<MessageEntity> searchMessages(
std::optional<std::string> timestampCursor, std::optional<std::string> timestampCursor,
std::optional<std::string> messageIDCursor) const override; std::optional<std::string> messageIDCursor) const override;
std::vector<MessageEntity> getRelatedMessagesForSearch( std::vector<MessageEntity> getRelatedMessagesForSearch(
const std::vector<std::string> &messageIDs) const override; const std::vector<std::string> &messageIDs) const override;
#ifdef EMSCRIPTEN #ifdef EMSCRIPTEN
std::vector<WebThread> getAllThreadsWeb() const override; std::vector<WebThread> getAllThreadsWeb() const override;
void replaceThreadWeb(const WebThread &thread) const override; void replaceThreadWeb(const WebThread &thread) const override;
std::vector<MessageWithMedias> getAllMessagesWeb() const override; std::vector<MessageWithMedias> getInitialMessagesWeb() const override;
void replaceMessageWeb(const WebMessage &message) const override; void replaceMessageWeb(const WebMessage &message) const override;
NullableString getOlmPersistAccountDataWeb(int accountID) const override; NullableString getOlmPersistAccountDataWeb(int accountID) const override;
std::vector<MessageWithMedias> std::vector<MessageWithMedias>
getRelatedMessagesWeb(const std::string &messageID) const override; getRelatedMessagesWeb(const std::string &messageID) const override;
std::vector<MessageWithMedias> searchMessagesWeb( std::vector<MessageWithMedias> searchMessagesWeb(
std::string query, std::string query,
std::string threadID, std::string threadID,
std::optional<std::string> timestampCursor, std::optional<std::string> timestampCursor,
Show All 10 Lines
View Options

web/shared-worker/_generated/comm_query_executor.wasm

Loading...
View Options

web/shared-worker/queries/fetch-messages-queries.test.js

Loading...
View Options

web/shared-worker/types/entities.js

Loading...
View Options

web/shared-worker/types/sqlite-query-executor.js

Loading...