Page MenuHomePhabricator

Update sendDMOperation to send notifs as well
ClosedPublic

Authored by marcin on Aug 20 2024, 7:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 3, 9:08 PM
Unknown Object (File)
Tue, Oct 22, 1:18 PM
Unknown Object (File)
Tue, Oct 22, 8:32 AM
Unknown Object (File)
Tue, Oct 22, 8:32 AM
Unknown Object (File)
Sep 25 2024, 3:09 PM
Unknown Object (File)
Sep 25 2024, 3:09 PM
Unknown Object (File)
Sep 25 2024, 3:09 PM
Unknown Object (File)
Sep 25 2024, 3:08 PM
Subscribers

Details

Summary

This differential updates sendDMOperation to create and send notifs as well

Test Plan
  1. Apply this patch: https://gist.github.com/marcinwasowicz/2db9332e8d59225d5549fe2e4e29d4cf
  2. Send message from web to native client.
  3. Ensure that client displays a list of different notifications including:
    1. text message notif
    2. thread creation notif
    3. reaction notif
    4. thread settings change notifs
    5. sidebar creation notif

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin edited the test plan for this revision. (Show Details)

Reflect changes in parent differential

Move notification sending logic to peer-to-peer-context

kamil added inline comments.
lib/shared/dm-ops/process-dm-ops.js
120–129 ↗(On Diff #43676)
lib/tunnelbroker/peer-to-peer-context.js
243–249 ↗(On Diff #43676)

could you make sure that none of those two promises throws?

This revision is now accepted and ready to land.Aug 27 2024, 8:09 AM
lib/shared/dm-ops/process-dm-ops.js
120–129 ↗(On Diff #43676)

Flow doesn't accept this.