Page MenuHomePhabricator
Differential D13181

[lib] update `creatorID` -> `unread` in `CreateThickRawThreadInfoInput`
ClosedPublic
Actions

Authored by kamil on Tue, Aug 27, 11:48 AM.
Tags
None
Referenced Files
F2788778: D13181.id43740.diff
Sat, Sep 21, 7:05 AM
F2788094: D13181.id43716.diff
Sat, Sep 21, 5:46 AM
F2787196: D13181.diff
Sat, Sep 21, 3:54 AM
Unknown Object (File)
Tue, Sep 17, 6:44 AM
Unknown Object (File)
Sun, Sep 15, 9:14 AM
Unknown Object (File)
Sat, Sep 14, 12:03 PM
Unknown Object (File)
Tue, Sep 10, 2:21 AM
Unknown Object (File)
Mon, Sep 9, 8:32 PM
View All 26 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
Commits
rCOMM097977552fcf: [lib] update `creatorID` -> `unread` in `CreateThickRawThreadInfoInput`
Summary

ENG-8568

We need to use CreateThickRawThreadInfoInput when creating ADD_VIEWER_TO_THREAD_MEMBERS, where it's complicated to retrieve creatorID.

creatorID is used only for computing unread, that being said we can simplify this.

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Branch
logic-2
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
2 lines
6 lines
types/
4 lines

Diff 43716

View Options

lib/shared/dm-ops/create-sidebar-spec.js

Loading...
View Options

lib/shared/dm-ops/create-thread-spec.js

Loading...
View Options

lib/types/dm-ops.js

Loading...