Page MenuHomePhabricator
Differential D13192

[lib] implement changing DM threads settings
ClosedPublic
Actions

Authored by kamil on Wed, Aug 28, 5:57 AM.
Tags
None
Referenced Files
F2788815: D13192.id43784.diff
Sat, Sep 21, 7:32 AM
F2788072: D13192.diff
Sat, Sep 21, 5:39 AM
Unknown Object (File)
Thu, Sep 19, 4:21 AM
Unknown Object (File)
Thu, Sep 19, 2:38 AM
Unknown Object (File)
Wed, Sep 18, 7:53 PM
Unknown Object (File)
Fri, Sep 13, 3:39 AM
Unknown Object (File)
Thu, Sep 12, 10:33 AM
Unknown Object (File)
Wed, Sep 11, 11:12 PM
View All 39 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
Commits
rCOMM0894c77808ea: [lib] implement changing DM threads settings
Summary

ENG-8979;

Because we can just return empty ChangeThreadSettingsPayload we were able to update this here, not in each component. This simplified things a lot, implicitly handled loading status, and saved a lot of other work.

To fully support avatars I created ENG-9102.

Test Plan

Test:

  1. Changing thread name
  2. Changing thread description
  3. Changing thread colors
  4. Changing thread avatars (only emojis)

Diff Detail

Repository
rCOMM Comm
Branch
logic-3
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Wed, Aug 28, 5:57 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptWed, Aug 28, 5:57 AM
Harbormaster completed remote builds in B31329: Diff 43737.Wed, Aug 28, 6:14 AM
kamil updated this revision to Diff 43749.Wed, Aug 28, 7:28 AM

update

kamil edited the summary of this revision. (Show Details)Wed, Aug 28, 7:33 AM
kamil edited the test plan for this revision. (Show Details)
kamil added a parent revision: D13193: [lib] make it possible to send DM ops to all thread members.
kamil mentioned this in D13195: [lib] remove `newMemberIDs` from `DMThreadSettingsChanges`.Wed, Aug 28, 7:42 AM
kamil published this revision for review.Wed, Aug 28, 7:43 AM
kamil added a child revision: D13195: [lib] remove `newMemberIDs` from `DMThreadSettingsChanges`.
Harbormaster completed remote builds in B31339: Diff 43749.Wed, Aug 28, 7:45 AM
tomek accepted this revision.Wed, Aug 28, 9:13 AM
tomek added inline comments.
web/modals/threads/settings/thread-settings-utils.js
87 ↗(On Diff #43749)

Why do we use null here?

This revision is now accepted and ready to land.Wed, Aug 28, 9:13 AM
kamil added inline comments.Thu, Aug 29, 12:18 AM
web/modals/threads/settings/thread-settings-utils.js
87 ↗(On Diff #43749)

removed

kamil updated this revision to Diff 43777.Thu, Aug 29, 12:19 AM

address review

Harbormaster completed remote builds in B31357: Diff 43777.Thu, Aug 29, 12:36 AM
Closed by commit rCOMM0894c77808ea: [lib] implement changing DM threads settings (authored by kamil). · Explain WhyThu, Aug 29, 1:16 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM0894c77808ea: [lib] implement changing DM threads settings.

Revision Contents
Changeset List

PathSize
lib/
actions/
82 lines
components/
6 lines
native/
chat/
settings/
4 lines
2 lines
2 lines
web/
modals/
threads/
settings/
4 lines

Diff 43737

View Options

lib/actions/thread-actions.js

Loading...
View Options

lib/components/base-edit-thread-avatar-provider.react.js

Loading...
View Options

native/chat/settings/color-selector-modal.react.js

Loading...
View Options

native/chat/settings/thread-settings-description.react.js

Loading...
View Options

native/chat/settings/thread-settings-name.react.js

Loading...
View Options

web/modals/threads/settings/thread-settings-utils.js

Loading...