Page MenuHomePhabricator
Differential D13181

[lib] update `creatorID` -> `unread` in `CreateThickRawThreadInfoInput`
ClosedPublic
Actions

Authored by kamil on Aug 27 2024, 11:48 AM.
Tags
None
Referenced Files
F3357059: D13181.id43740.diff
Sat, Nov 23, 10:05 PM
Unknown Object (File)
Wed, Nov 6, 10:34 PM
Unknown Object (File)
Wed, Nov 6, 10:34 PM
Unknown Object (File)
Wed, Nov 6, 10:34 PM
Unknown Object (File)
Wed, Nov 6, 10:04 PM
Unknown Object (File)
Mon, Nov 4, 1:35 PM
Unknown Object (File)
Oct 6 2024, 8:43 PM
Unknown Object (File)
Oct 6 2024, 8:43 PM
View All 38 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
Commits
rCOMM097977552fcf: [lib] update `creatorID` -> `unread` in `CreateThickRawThreadInfoInput`
Summary

ENG-8568

We need to use CreateThickRawThreadInfoInput when creating ADD_VIEWER_TO_THREAD_MEMBERS, where it's complicated to retrieve creatorID.

creatorID is used only for computing unread, that being said we can simplify this.

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
2 lines
6 lines
types/
4 lines

Diff 43740

View Options

lib/shared/dm-ops/create-sidebar-spec.js

Loading...
View Options

lib/shared/dm-ops/create-thread-spec.js

Loading...
View Options

lib/types/dm-ops.js

Loading...