Paths

Table of Contentst

[lib][native] update `useEditMessage` return type
ClosedPublic
Actions

Authored by kamil on Aug 28 2024, 2:53 AM.

Details

Reviewers

tomek
inka

Commits

rCOMM6cc6e90afda0: [lib][native] update `useEditMessage` return type

Summary

ENG-8976;

SendEditMessageResult is used only in dispatchActionPromise, other than that we only care about success/failure.

With that change, we're able to use this hook also for DMs where SendEditMessageResult is not existing.

Test Plan

Editing still works

Diff Detail

Repository

rCOMM Comm

Branch

logic-4

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Aug 28 2024, 2:53 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptAug 28 2024, 2:53 AM

kamil added a child revision: D13187: [lib] add editing DM messages.Aug 28 2024, 2:56 AM

Harbormaster completed remote builds in B31314: Diff 43722.Aug 28 2024, 3:12 AM

kamil published this revision for review.Aug 28 2024, 3:59 AM

tomek accepted this revision.Aug 28 2024, 5:34 AM

tomek added inline comments.

lib/shared/edit-messages-utils.js
28–48 ↗	(On Diff #43722)	We can simplify the syntax

This revision is now accepted and ready to land.Aug 28 2024, 5:34 AM

kamil added a parent revision: D13193: [lib] make it possible to send DM ops to all thread members.Aug 28 2024, 6:24 AM

simplify syntax

Harbormaster completed remote builds in B31334: Diff 43744.Aug 28 2024, 6:56 AM

Closed by commit rCOMM6cc6e90afda0: [lib][native] update `useEditMessage` return type (authored by kamil). · Explain WhyAug 28 2024, 8:33 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM6cc6e90afda0: [lib][native] update `useEditMessage` return type.

Revision Contents
Changeset List

Path

Size

lib/

shared/

edit-messages-utils.js

7 lines

native/

chat/

chat-input-bar.react.js

10 lines

Diff 43744

View Options

lib/shared/edit-messages-utils.js