Page MenuHomePhabricator
Differential D13184

[native] implement leaving DM thread
ClosedPublic
Actions

Authored by kamil on Aug 28 2024, 2:51 AM.
Tags
None
Referenced Files
F3389068: D13184.diff
Fri, Nov 29, 5:24 PM
Unknown Object (File)
Sat, Nov 23, 9:26 PM
Unknown Object (File)
Sat, Nov 23, 8:34 PM
Unknown Object (File)
Sat, Nov 23, 8:21 PM
Unknown Object (File)
Sat, Nov 23, 6:55 PM
Unknown Object (File)
Wed, Nov 6, 10:19 PM
Unknown Object (File)
Wed, Nov 6, 10:19 PM
Unknown Object (File)
Wed, Nov 6, 10:19 PM
View All 64 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
Commits
rCOMMbda52676cecc: [native] implement leaving DM thread
Summary

ENG-8977

Updating component logic.

Test Plan
  1. Created thread with users A and B.
  2. On A leave thread.
  3. B see that A left, thread disappeared for A.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Aug 28 2024, 2:51 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptAug 28 2024, 2:51 AM
kamil added a child revision: D13185: [web] implement leaving DM thread.Aug 28 2024, 2:52 AM
Harbormaster completed remote builds in B31312: Diff 43720.Aug 28 2024, 3:07 AM
kamil published this revision for review.Aug 28 2024, 3:57 AM
tomek accepted this revision.Aug 28 2024, 5:32 AM
tomek added inline comments.
native/chat/settings/thread-settings-leave-thread.react.js
128 ↗(On Diff #43720)

Not sure if it is a good idea to have this comment here. We won't be updating this place when implementing ENG-9098.

This revision is now accepted and ready to land.Aug 28 2024, 5:32 AM
kamil updated this revision to Diff 43752.Aug 28 2024, 7:48 AM

remove comment

kamil added a parent revision: D13193: [lib] make it possible to send DM ops to all thread members.Aug 28 2024, 7:49 AM
Harbormaster failed remote builds in B31341: Diff 43752!Aug 28 2024, 7:58 AM
kamil updated this revision to Diff 43754.Aug 28 2024, 7:59 AM

fix flow

Harbormaster completed remote builds in B31343: Diff 43754.Aug 28 2024, 8:16 AM
Closed by commit rCOMMbda52676cecc: [native] implement leaving DM thread (authored by kamil). · Explain WhyAug 28 2024, 8:33 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMbda52676cecc: [native] implement leaving DM thread.

Revision Contents
Changeset List

PathSize
native/
chat/
settings/
73 lines

Diff 43761

View Options

native/chat/settings/thread-settings-leave-thread.react.js

Loading...