Page MenuHomePhabricator
Differential D13184

[native] implement leaving DM thread
ClosedPublic
Actions

Authored by kamil on Wed, Aug 28, 2:51 AM.
Tags
None
Referenced Files
F2788850: D13184.id43752.diff
Sat, Sep 21, 7:49 AM
F2788849: D13184.id43754.diff
Sat, Sep 21, 7:48 AM
F2788841: D13184.id43720.diff
Sat, Sep 21, 7:45 AM
F2788836: D13184.id43761.diff
Sat, Sep 21, 7:42 AM
F2788013: D13184.diff
Sat, Sep 21, 5:34 AM
Unknown Object (File)
Wed, Sep 18, 10:56 AM
Unknown Object (File)
Wed, Sep 18, 7:43 AM
Unknown Object (File)
Tue, Sep 17, 3:38 PM
View All 33 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
Commits
rCOMMbda52676cecc: [native] implement leaving DM thread
Summary

ENG-8977

Updating component logic.

Test Plan
  1. Created thread with users A and B.
  2. On A leave thread.
  3. B see that A left, thread disappeared for A.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Wed, Aug 28, 2:51 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptWed, Aug 28, 2:51 AM
kamil added a child revision: D13185: [web] implement leaving DM thread.Wed, Aug 28, 2:52 AM
Harbormaster completed remote builds in B31312: Diff 43720.Wed, Aug 28, 3:07 AM
kamil published this revision for review.Wed, Aug 28, 3:57 AM
tomek accepted this revision.Wed, Aug 28, 5:32 AM
tomek added inline comments.
native/chat/settings/thread-settings-leave-thread.react.js
128 ↗(On Diff #43720)

Not sure if it is a good idea to have this comment here. We won't be updating this place when implementing ENG-9098.

This revision is now accepted and ready to land.Wed, Aug 28, 5:32 AM
kamil updated this revision to Diff 43752.Wed, Aug 28, 7:48 AM

remove comment

kamil added a parent revision: D13193: [lib] make it possible to send DM ops to all thread members.Wed, Aug 28, 7:49 AM
Harbormaster failed remote builds in B31341: Diff 43752!Wed, Aug 28, 7:58 AM
kamil updated this revision to Diff 43754.Wed, Aug 28, 7:59 AM

fix flow

Harbormaster completed remote builds in B31343: Diff 43754.Wed, Aug 28, 8:16 AM
Closed by commit rCOMMbda52676cecc: [native] implement leaving DM thread (authored by kamil). · Explain WhyWed, Aug 28, 8:33 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMbda52676cecc: [native] implement leaving DM thread.

Revision Contents
Changeset List

PathSize
native/
chat/
settings/
73 lines

Diff 43761

View Options

native/chat/settings/thread-settings-leave-thread.react.js

Loading...