Page MenuHomePhabricator
Differential D13197

[lib] implement adding thread members for DMs
ClosedPublic
Actions

Authored by kamil on Aug 28 2024, 8:37 AM.
Tags
None
Referenced Files
F5584916: D13197.id43786.diff
Sat, Apr 12, 9:19 PM
Unknown Object (File)
Sun, Apr 6, 5:23 AM
Unknown Object (File)
Wed, Mar 26, 8:35 AM
Unknown Object (File)
Mar 11 2025, 2:36 PM
Unknown Object (File)
Mar 5 2025, 10:13 PM
Unknown Object (File)
Mar 5 2025, 1:57 PM
Unknown Object (File)
Mar 5 2025, 9:25 AM
Unknown Object (File)
Mar 4 2025, 10:34 PM
View All 96 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
Commits
rCOMM80bd999464a2: [lib] implement adding thread members for DMs
Summary

ENG-8568

This hook which wraps two needed operations together, add_viewer_to_thread_members and add_members.

Doing this in parallel, not at once is bad, created a task to fix this: ENG-9103, as this is complex change.

Depends on D13182, D13193

Test Plan

Tested later in the stack

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Aug 28 2024, 8:37 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptAug 28 2024, 8:37 AM
kamil updated this revision to Diff 43766.Aug 28 2024, 8:45 AM

update recipients

Harbormaster failed remote builds in B31347: Diff 43765!Aug 28 2024, 8:46 AM
kamil added a child revision: D13198: [native] implement adding thread members in `AddUsersModal`.Aug 28 2024, 8:47 AM
Harbormaster failed remote builds in B31348: Diff 43766!Aug 28 2024, 8:51 AM
Harbormaster completed remote builds in B31348: Diff 43766.Aug 28 2024, 9:03 AM
kamil published this revision for review.Aug 28 2024, 9:33 AM
kamil edited the summary of this revision. (Show Details)
tomek accepted this revision.Aug 28 2024, 9:56 AM
tomek added inline comments.
lib/shared/dm-ops/dm-op-utils.js
172 ↗(On Diff #43766)
222 ↗(On Diff #43766)

Maybe await?

This revision is now accepted and ready to land.Aug 28 2024, 9:56 AM
kamil updated this revision to Diff 43779.Aug 29 2024, 12:21 AM

address review

Harbormaster completed remote builds in B31359: Diff 43779.Aug 29 2024, 12:46 AM
Closed by commit rCOMM80bd999464a2: [lib] implement adding thread members for DMs (authored by kamil). · Explain WhyAug 29 2024, 1:16 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM80bd999464a2: [lib] implement adding thread members for DMs.

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
117 lines

Diff 43779

View Options

lib/shared/dm-ops/dm-op-utils.js

// @flow // @flow
import { unsupervisedBackgroundActionType } from './lifecycle-state-reducer.js'; import { unsupervisedBackgroundActionType } from './lifecycle-state-reducer.js';
import { updateActivityActionTypes } from '../actions/activity-actions.js'; import { updateActivityActionTypes } from '../actions/activity-actions.js';
import { setClientDBStoreActionType } from '../actions/client-db-store-actions.js';
import { import {
updateLastCommunicatedPlatformDetailsActionType, updateLastCommunicatedPlatformDetailsActionType,
setDeviceTokenActionTypes, setDeviceTokenActionTypes,
} from '../actions/device-actions.js'; } from '../actions/device-actions.js';
import { import {
addKeyserverActionType, addKeyserverActionType,
removeKeyserverActionType, removeKeyserverActionType,
} from '../actions/keyserver-actions.js'; } from '../actions/keyserver-actions.js';
Show All 10 Lines
import { setNewSessionActionType } from '../keyserver-conn/keyserver-conn-types.js'; import { setNewSessionActionType } from '../keyserver-conn/keyserver-conn-types.js';
import { import {
keyserverStoreOpsHandlers, keyserverStoreOpsHandlers,
type ReplaceKeyserverOperation, type ReplaceKeyserverOperation,
type RemoveKeyserversOperation, type RemoveKeyserversOperation,
type KeyserverStoreOperation, type KeyserverStoreOperation,
} from '../ops/keyserver-store-ops.js'; } from '../ops/keyserver-store-ops.js';
import { queueActivityUpdatesActionType } from '../types/activity-types.js'; import { queueActivityUpdatesActionType } from '../types/activity-types.js';
import type { KeyserverStore } from '../types/keyserver-types.js'; import type {
KeyserverInfos,
KeyserverStore,
} from '../types/keyserver-types.js';
import type { BaseAction } from '../types/redux-types.js'; import type { BaseAction } from '../types/redux-types.js';
import { import {
fullStateSyncActionType, fullStateSyncActionType,
incrementalStateSyncActionType, incrementalStateSyncActionType,
updateConnectionStatusActionType, updateConnectionStatusActionType,
setLateResponseActionType, setLateResponseActionType,
updateKeyserverReachabilityActionType, updateKeyserverReachabilityActionType,
setConnectionIssueActionType, setConnectionIssueActionType,
} from '../types/socket-types.js'; } from '../types/socket-types.js';
import { updateTypes } from '../types/update-types-enum.js'; import { updateTypes } from '../types/update-types-enum.js';
import { processUpdatesActionType } from '../types/update-types.js'; import { processUpdatesActionType } from '../types/update-types.js';
import { getConfig } from '../utils/config.js'; import { getConfig } from '../utils/config.js';
import { getMessageForException } from '../utils/errors.js';
import { assertObjectsAreEqual } from '../utils/objects.js';
import { setURLPrefix } from '../utils/url-utils.js'; import { setURLPrefix } from '../utils/url-utils.js';
import { ashoatKeyserverID } from '../utils/validation-utils.js'; import { ashoatKeyserverID } from '../utils/validation-utils.js';
function assertKeyserverStoresAreEqual(
processedKeyserverStore: KeyserverInfos,
expectedKeyserverStore: KeyserverInfos,
location: string,
onStateDifference?: (message: string) => mixed,
) {
try {
assertObjectsAreEqual(
processedKeyserverStore,
expectedKeyserverStore,
`KeyserverInfos - ${location}`,
);
} catch (e) {
console.log(
'Error processing KeyserverStore ops',
processedKeyserverStore,
expectedKeyserverStore,
);
const message = `Error processing KeyserverStore ops ${
getMessageForException(e) ?? '{no exception message}'
}`;
onStateDifference?.(message);
}
}
const { processStoreOperations: processStoreOps } = keyserverStoreOpsHandlers; const { processStoreOperations: processStoreOps } = keyserverStoreOpsHandlers;
export default function reduceKeyserverStore( export default function reduceKeyserverStore(
state: KeyserverStore, state: KeyserverStore,
action: BaseAction, action: BaseAction,
onStateDifference?: (message: string) => mixed,
): { ): {
keyserverStore: KeyserverStore, keyserverStore: KeyserverStore,
keyserverStoreOperations: $ReadOnlyArray<KeyserverStoreOperation>, keyserverStoreOperations: $ReadOnlyArray<KeyserverStoreOperation>,
} { } {
if (action.type === addKeyserverActionType) { if (action.type === addKeyserverActionType) {
const replaceOperation: ReplaceKeyserverOperation = { const replaceOperation: ReplaceKeyserverOperation = {
type: 'replace_keyserver', type: 'replace_keyserver',
payload: { payload: {
▲ Show 20 Lines • Show All 548 Lines • ▼ Show 20 Lines ) {
}; };
return { return {
keyserverStore: { keyserverStore: {
...state, ...state,
keyserverInfos: processStoreOps(state.keyserverInfos, [operation]), keyserverInfos: processStoreOps(state.keyserverInfos, [operation]),
}, },
keyserverStoreOperations: [operation], keyserverStoreOperations: [operation],
}; };
} else if (action.type === setClientDBStoreActionType) {
// Once the functionality is confirmed to work correctly,
// we will proceed with returning keyserverInfos from the payload.
assertKeyserverStoresAreEqual(
action.payload.keyserverInfos ?? {},
state.keyserverInfos,
action.type,
onStateDifference,
);
return {
keyserverStore: state,
keyserverStoreOperations: [],
};
} }
return { return {
keyserverStore: state, keyserverStore: state,
keyserverStoreOperations: [], keyserverStoreOperations: [],
}; };
} }