Page MenuHomePhabricator

[lib] implement changing DM threads settings
ClosedPublic

Authored by kamil on Aug 28 2024, 5:57 AM.
Tags
None
Referenced Files
F3379074: D13192.id43777.diff
Wed, Nov 27, 3:07 PM
F3378806: D13192.diff
Wed, Nov 27, 1:13 PM
Unknown Object (File)
Sun, Nov 24, 12:49 AM
Unknown Object (File)
Sat, Nov 23, 10:45 PM
Unknown Object (File)
Wed, Nov 6, 10:19 PM
Unknown Object (File)
Wed, Nov 6, 10:19 PM
Unknown Object (File)
Wed, Nov 6, 10:19 PM
Unknown Object (File)
Wed, Nov 6, 10:19 PM
Subscribers

Details

Summary

ENG-8979;

Because we can just return empty ChangeThreadSettingsPayload we were able to update this here, not in each component. This simplified things a lot, implicitly handled loading status, and saved a lot of other work.

To fully support avatars I created ENG-9102.

Test Plan

Test:

  1. Changing thread name
  2. Changing thread description
  3. Changing thread colors
  4. Changing thread avatars (only emojis)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil edited the test plan for this revision. (Show Details)
tomek added inline comments.
web/modals/threads/settings/thread-settings-utils.js
87 ↗(On Diff #43749)

Why do we use null here?

This revision is now accepted and ready to land.Aug 28 2024, 9:13 AM
web/modals/threads/settings/thread-settings-utils.js
87 ↗(On Diff #43749)

removed