Page MenuHomePhabricator
Differential D13197

[lib] implement adding thread members for DMs
ClosedPublic
Actions

Authored by kamil on Wed, Aug 28, 8:37 AM.
Tags
None
Referenced Files
F2789064: D13197.id43779.diff
Sat, Sep 21, 9:59 AM
F2788760: D13197.diff
Sat, Sep 21, 6:52 AM
F2788326: D13197.id43786.diff
Sat, Sep 21, 6:19 AM
Unknown Object (File)
Thu, Sep 19, 5:34 AM
Unknown Object (File)
Thu, Sep 19, 4:17 AM
Unknown Object (File)
Wed, Sep 18, 11:21 PM
Unknown Object (File)
Sat, Sep 14, 8:47 PM
Unknown Object (File)
Wed, Sep 11, 9:48 PM
View All 35 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
Commits
rCOMM80bd999464a2: [lib] implement adding thread members for DMs
Summary

ENG-8568

This hook which wraps two needed operations together, add_viewer_to_thread_members and add_members.

Doing this in parallel, not at once is bad, created a task to fix this: ENG-9103, as this is complex change.

Depends on D13182, D13193

Test Plan

Tested later in the stack

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Wed, Aug 28, 8:37 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptWed, Aug 28, 8:37 AM
kamil updated this revision to Diff 43766.Wed, Aug 28, 8:45 AM

update recipients

Harbormaster failed remote builds in B31347: Diff 43765!Wed, Aug 28, 8:46 AM
kamil added a child revision: D13198: [native] implement adding thread members in `AddUsersModal`.Wed, Aug 28, 8:47 AM
Harbormaster failed remote builds in B31348: Diff 43766!Wed, Aug 28, 8:51 AM
Harbormaster completed remote builds in B31348: Diff 43766.Wed, Aug 28, 9:03 AM
kamil published this revision for review.Wed, Aug 28, 9:33 AM
kamil edited the summary of this revision. (Show Details)
tomek accepted this revision.Wed, Aug 28, 9:56 AM
tomek added inline comments.
lib/shared/dm-ops/dm-op-utils.js
172 ↗(On Diff #43766)
222 ↗(On Diff #43766)

Maybe await?

This revision is now accepted and ready to land.Wed, Aug 28, 9:56 AM
kamil updated this revision to Diff 43779.Thu, Aug 29, 12:21 AM

address review

Harbormaster completed remote builds in B31359: Diff 43779.Thu, Aug 29, 12:46 AM
Closed by commit rCOMM80bd999464a2: [lib] implement adding thread members for DMs (authored by kamil). · Explain WhyThu, Aug 29, 1:16 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM80bd999464a2: [lib] implement adding thread members for DMs.

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
117 lines

Diff 43786

View Options

lib/shared/dm-ops/dm-op-utils.js

Loading...