Page MenuHomePhabricator
Differential D13222

[identity] Verify lastPrimarySignature for singleton lists
ClosedPublic
Actions

Authored by bartek on Sep 2 2024, 11:25 PM.
Tags
None
Referenced Files
F3197040: D13222.id43844.diff
Sat, Nov 9, 7:10 AM
Unknown Object (File)
Thu, Nov 7, 4:24 PM
Unknown Object (File)
Sun, Nov 3, 5:39 AM
Unknown Object (File)
Sun, Nov 3, 5:36 AM
Unknown Object (File)
Sun, Nov 3, 5:36 AM
Unknown Object (File)
Sun, Nov 3, 5:25 AM
Unknown Object (File)
Tue, Oct 29, 9:57 AM
Unknown Object (File)
Tue, Oct 22, 6:30 PM
View All 43 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
kamil
Commits
rCOMMa204eb8ceed3: [identity] Verify lastPrimarySignature for singleton lists
Summary

Required for ENG-8212.
In case of backup restore, the singleton device list will also have lastPrimarySignature, which wasn't accepted before for singleton device lists.

Test Plan

Existing tests still pass.
Tested manually with lastPrimarySignature being present:

  • Passes with no last primary signature provided and none expected (previous behavior unchanged)
  • Fails if signature provided but none expected
  • Fails no signature is provided but one is expected
  • Passes if valid signature is provided and it's expected (previous signing key provided)
  • Fails if signature verification fails for given signing public key

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Sep 2 2024, 11:25 PM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 2 2024, 11:25 PM
bartek added a child revision: D13223: [identity] Update SignedDeviceList::from_str to return tonic::Status.Sep 2 2024, 11:27 PM
bartek mentioned this in D13224: [identity] Allow register_primary_device() to overwrite device list.Sep 2 2024, 11:33 PM
Harbormaster completed remote builds in B31398: Diff 43844.Sep 2 2024, 11:42 PM
bartek mentioned this in D13226: [identity] Implement RestoreUser RPCs.Sep 2 2024, 11:43 PM
bartek published this revision for review.Sep 3 2024, 12:04 AM
kamil accepted this revision.Sep 6 2024, 5:43 AM
This revision is now accepted and ready to land.Sep 6 2024, 5:43 AM
Closed by commit rCOMMa204eb8ceed3: [identity] Verify lastPrimarySignature for singleton lists (authored by bartek). · Explain WhySep 9 2024, 6:21 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMa204eb8ceed3: [identity] Verify lastPrimarySignature for singleton lists.
bartek mentioned this in rCOMMbee39ec012b7: [identity] Allow register_primary_device() to overwrite device list.
bartek mentioned this in rCOMM817c5955a206: [identity] Implement RestoreUser RPCs.Sep 13 2024, 3:36 AM

Revision Contents
Changeset List

PathSize
services/
identity/
src/
44 lines
grpc_services/
1 line
1 line

Diff 43844

View Options

services/identity/src/device_list.rs

Loading...
View Options

services/identity/src/grpc_services/authenticated.rs

Loading...
View Options

services/identity/src/grpc_utils.rs

Loading...