Page MenuHomePhabricator
Differential D13223

[identity] Update SignedDeviceList::from_str to return tonic::Status
ClosedPublic
Actions

Authored by bartek on Sep 2 2024, 11:27 PM.
Tags
None
Referenced Files
F5255602: D13223.diff
Sun, Apr 6, 8:31 AM
Unknown Object (File)
Sat, Mar 15, 4:05 AM
Unknown Object (File)
Mar 6 2025, 8:54 PM
Unknown Object (File)
Mar 1 2025, 2:59 AM
Unknown Object (File)
Feb 26 2025, 11:38 AM
Unknown Object (File)
Feb 26 2025, 11:38 AM
Unknown Object (File)
Feb 26 2025, 11:37 AM
Unknown Object (File)
Feb 22 2025, 12:47 PM
View All 54 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
will
kamil
Commits
rCOMM8e7230210185: [identity] Update SignedDeviceList::from_str to return tonic::Status
Summary

Noticed that we're using type Error = serde_json::Error in FromStr, but we map it everywhere to tonic::Status.
Refactored this to map it only in one place and avoid adding another mapping in the next diff

Depends on D13222

Test Plan

cargo build -p identity

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
services/
identity/
src/
16 lines
grpc_services/
7 lines

Diff 43845

View Options

services/identity/src/device_list.rs

// @flow // @flow
'use strict'; 'use strict';
import { TurboModuleRegistry } from 'react-native'; import { TurboModuleRegistry } from 'react-native';
import type { TurboModule } from 'react-native/Libraries/TurboModule/RCTExport.js'; import type { TurboModule } from 'react-native/Libraries/TurboModule/RCTExport.js';
// codegen doesn't understand ArrayBuffers, so we need to map them to Objects // codegen doesn't understand ArrayBuffers, so we need to map them to Objects
type JSIArrayBuffer = Object; type JSIArrayBuffer = Object;
interface Spec extends TurboModule { interface Spec extends TurboModule {
// filesystem utils // filesystem utils
+writeBufferToFile: (path: string, data: JSIArrayBuffer) => Promise<void>; +writeBufferToFile: (path: string, data: JSIArrayBuffer) => Promise<void>;
+readBufferFromFile: (path: string) => Promise<JSIArrayBuffer>; +readBufferFromFile: (path: string) => Promise<JSIArrayBuffer>;
+base64EncodeBuffer: (data: JSIArrayBuffer) => string; +base64EncodeBuffer: (data: JSIArrayBuffer) => string;
+base64DecodeBuffer: (base64: string) => JSIArrayBuffer;
// crypto utils // crypto utils
+sha256: (data: JSIArrayBuffer) => string; +sha256: (data: JSIArrayBuffer) => string;
} }
// for public interface, we use the correct types // for public interface, we use the correct types
export interface UtilsModuleSpec { export interface UtilsModuleSpec {
+writeBufferToFile: (path: string, data: ArrayBuffer) => Promise<void>; +writeBufferToFile: (path: string, data: ArrayBuffer) => Promise<void>;
+readBufferFromFile: (path: string) => Promise<ArrayBuffer>; +readBufferFromFile: (path: string) => Promise<ArrayBuffer>;
+base64EncodeBuffer: (data: ArrayBuffer) => string; +base64EncodeBuffer: (data: ArrayBuffer) => string;
+base64DecodeBuffer: (base64: string) => ArrayBuffer;
+sha256: (data: ArrayBuffer) => string; +sha256: (data: ArrayBuffer) => string;
} }
export default (TurboModuleRegistry.getEnforcing<Spec>( export default (TurboModuleRegistry.getEnforcing<Spec>(
'CommUtilsTurboModule', 'CommUtilsTurboModule',
): Spec); ): Spec);
View Options

services/identity/src/grpc_services/authenticated.rs

// @flow // @flow
'use strict'; 'use strict';
import { TurboModuleRegistry } from 'react-native'; import { TurboModuleRegistry } from 'react-native';
import type { TurboModule } from 'react-native/Libraries/TurboModule/RCTExport.js'; import type { TurboModule } from 'react-native/Libraries/TurboModule/RCTExport.js';
// codegen doesn't understand ArrayBuffers, so we need to map them to Objects // codegen doesn't understand ArrayBuffers, so we need to map them to Objects
type JSIArrayBuffer = Object; type JSIArrayBuffer = Object;
interface Spec extends TurboModule { interface Spec extends TurboModule {
// filesystem utils // filesystem utils
+writeBufferToFile: (path: string, data: JSIArrayBuffer) => Promise<void>; +writeBufferToFile: (path: string, data: JSIArrayBuffer) => Promise<void>;
+readBufferFromFile: (path: string) => Promise<JSIArrayBuffer>; +readBufferFromFile: (path: string) => Promise<JSIArrayBuffer>;
+base64EncodeBuffer: (data: JSIArrayBuffer) => string; +base64EncodeBuffer: (data: JSIArrayBuffer) => string;
+base64DecodeBuffer: (base64: string) => JSIArrayBuffer;
// crypto utils // crypto utils
+sha256: (data: JSIArrayBuffer) => string; +sha256: (data: JSIArrayBuffer) => string;
} }
// for public interface, we use the correct types // for public interface, we use the correct types
export interface UtilsModuleSpec { export interface UtilsModuleSpec {
+writeBufferToFile: (path: string, data: ArrayBuffer) => Promise<void>; +writeBufferToFile: (path: string, data: ArrayBuffer) => Promise<void>;
+readBufferFromFile: (path: string) => Promise<ArrayBuffer>; +readBufferFromFile: (path: string) => Promise<ArrayBuffer>;
+base64EncodeBuffer: (data: ArrayBuffer) => string; +base64EncodeBuffer: (data: ArrayBuffer) => string;
+base64DecodeBuffer: (base64: string) => ArrayBuffer;
+sha256: (data: ArrayBuffer) => string; +sha256: (data: ArrayBuffer) => string;
} }
export default (TurboModuleRegistry.getEnforcing<Spec>( export default (TurboModuleRegistry.getEnforcing<Spec>(
'CommUtilsTurboModule', 'CommUtilsTurboModule',
): Spec); ): Spec);