Differential D13165

Return single curve25519 string from NotificationsInboundKeysProvider
ClosedPublic
Actions

Authored by marcin on Aug 26 2024, 4:58 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 10, 12:43 PM

	Unknown Object (File)
	Sat, Nov 9, 3:34 PM

	Unknown Object (File)
	Fri, Nov 8, 11:23 PM

	Unknown Object (File)
	Sun, Nov 3, 9:08 PM

	Unknown Object (File)
	Tue, Oct 22, 1:18 PM

	Unknown Object (File)
	Tue, Oct 22, 8:32 AM

	Unknown Object (File)
	Oct 18 2024, 7:20 PM

	Unknown Object (File)
	Oct 7 2024, 8:10 PM

View All 33 Files

Subscribers

Details

Reviewers

Commits

rCOMMb6731e53850c: Return single curve25519 string from NotificationsInboundKeysProvider

Summary

This differential returns only curve25519 key string from native code and creates JSON in C++ with folly instead of creating JSON in native code. The rieason for this change is that we saw issues with the content of the JSON returned from Java - Android app was unable to create session as inbound since sender identity key was corrupted. This change fixed the issue.

Test Plan

Before this diff creating notifs session with Android device as inboud would fail each (> 90%) of the times.
After this diff it always works.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Aug 26 2024, 4:58 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 26 2024, 4:58 AM

marcin added a parent revision: D13164: Implement code in lib to create thick threads rescinds and badge updates.Aug 26 2024, 4:59 AM

marcin added a child revision: D13166: Enrich CommMMKV api with operations that manipulate string set.Aug 26 2024, 5:03 AM

Harbormaster completed remote builds in B31254: Diff 43629.Aug 26 2024, 5:15 AM

marcin requested review of this revision.Aug 26 2024, 5:15 AM

kamil accepted this revision.Aug 28 2024, 9:41 AM

This revision is now accepted and ready to land.Aug 28 2024, 9:41 AM

Rebase before landing

Harbormaster completed remote builds in B31415: Diff 43861.Sep 3 2024, 7:47 AM

Closed by commit rCOMMb6731e53850c: Return single curve25519 string from NotificationsInboundKeysProvider (authored by Marcin Wąsowicz <marcinwasowicz@MacBook-Pro-Marcin.local>). · Explain WhySep 3 2024, 8:20 AM

This revision was automatically updated to reflect the committed changes.

Marcin Wąsowicz <marcinwasowicz@MacBook-Pro-Marcin.local> added a commit: rCOMMb6731e53850c: Return single curve25519 string from NotificationsInboundKeysProvider.

Revision Contents
Changeset List

Path

Size

native/

android/

app/

src/

main/

java/

app/

comm/

android/

fbjni/

NotificationsInboundKeysProvider.java

10 lines

cpp/

CommonCpp/

Notifications/

BackgroundDataStorage/

NotificationsCryptoModule.cpp

12 lines

ios/

Comm/

NotificationsInboundKeysProvider.mm

9 lines

Diff 43861

native/android/app/src/main/java/app/comm/android/fbjni/NotificationsInboundKeysProvider.java

Loading...

native/cpp/CommonCpp/Notifications/BackgroundDataStorage/NotificationsCryptoModule.cpp

Loading...

native/ios/Comm/NotificationsInboundKeysProvider.mm

Loading...