Page MenuHomePhabricator
Differential D13188

Add method to set entire sttring set at once in MMKV
ClosedPublic
Actions

Authored by marcin on Aug 28 2024, 3:02 AM.
Tags
None
Referenced Files
F3005763: D13188.id43873.diff
Fri, Oct 18, 5:17 PM
F3005762: D13188.id43864.diff
Fri, Oct 18, 5:17 PM
F3005761: D13188.id43724.diff
Fri, Oct 18, 5:17 PM
F3005627: D13188.diff
Fri, Oct 18, 5:15 PM
Unknown Object (File)
Wed, Oct 16, 7:39 AM
Unknown Object (File)
Thu, Oct 10, 12:01 PM
Unknown Object (File)
Sat, Sep 28, 1:01 PM
Unknown Object (File)
Fri, Sep 27, 9:38 AM
View All 26 Files
Subscribers
ashoat

Details

Reviewers
bartek
kamil
tomek
Commits
rCOMM2f46287fff9e: Add method to set entire sttring set at once in MMKV
Summary

This differential adds method that allows to set entire set of strings at once in MMKV. It will be necessary since push-handler component wil update set of unread thread IDs in MMKV when it is connected to Tunnelbroker

Test Plan

tested in the diff after the next one.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Aug 28 2024, 3:02 AM
Herald added a subscriber: ashoat. · View Herald TranscriptAug 28 2024, 3:02 AM
marcin added a parent revision: D13167: Implement thick thread badge updates and rescinds handling in native notifs code.Aug 28 2024, 3:03 AM
marcin added a child revision: D13189: JSI to update unread thick thread IDs in MMKV.Aug 28 2024, 3:07 AM
Harbormaster completed remote builds in B31316: Diff 43724.Aug 28 2024, 3:23 AM
marcin requested review of this revision.Aug 28 2024, 3:23 AM
tomek accepted this revision.Aug 29 2024, 6:08 AM
This revision is now accepted and ready to land.Aug 29 2024, 6:08 AM
marcin updated this revision to Diff 43864.Sep 3 2024, 7:30 AM

Rebase before landing

Harbormaster completed remote builds in B31418: Diff 43864.Sep 3 2024, 7:59 AM
Closed by commit rCOMM2f46287fff9e: Add method to set entire sttring set at once in MMKV (authored by Marcin Wąsowicz <marcinwasowicz@MacBook-Pro-Marcin.local>). · Explain WhySep 3 2024, 8:20 AM
This revision was automatically updated to reflect the committed changes.
Marcin Wąsowicz <marcinwasowicz@MacBook-Pro-Marcin.local> added a commit: rCOMM2f46287fff9e: Add method to set entire sttring set at once in MMKV.

Revision Contents
Changeset List

PathSize
native/
android/
app/
src/
cpp/
25 lines
main/
java/
app/
comm/
android/
fbjni/
7 lines
cpp/
CommonCpp/
Tools/
2 lines
ios/
Comm/
22 lines

Diff 43864

View Options

native/android/app/src/cpp/CommMMKV.cpp

Loading...
View Options

native/android/app/src/main/java/app/comm/android/fbjni/CommMMKV.java

Loading...
View Options

native/cpp/CommonCpp/Tools/CommMMKV.h

Loading...
View Options

native/ios/Comm/CommMMKV.mm

Loading...