Page MenuHomePhabricator
Differential D13190

Update badge count from JS on native taking into account thick threads
ClosedPublic
Actions

Authored by marcin on Aug 28 2024, 3:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 3:11 PM
Unknown Object (File)
Wed, Dec 18, 3:11 PM
Unknown Object (File)
Wed, Dec 18, 3:11 PM
Unknown Object (File)
Wed, Dec 18, 3:11 PM
Unknown Object (File)
Wed, Dec 18, 3:11 PM
Unknown Object (File)
Wed, Dec 18, 3:11 PM
Unknown Object (File)
Sat, Nov 30, 11:35 AM
Unknown Object (File)
Nov 18 2024, 9:56 AM
View All 71 Files
Subscribers
ashoat

Details

Reviewers
kamil
tomek
Commits
rCOMMc60c0337be1f: Update badge count from JS on native taking into account thick threads
Summary

This differential uses JSI from previous differential to update badge count by taking into account unread thick threads. The algorithm is the same as for the keyservers:

  1. If we are connected to the tunnelbroker, we trust redux and update notifs storage (MMKV) with data from redux.
  2. If we are disconnected from the tunnelbroker, we trust notifs storage (MMKV) and fetch data from there.
  3. We sum the number of unread thick threads and partial unread counts for each keyserver to get the total unread count.
  4. We set badge count to total unread count.
Test Plan
  1. Apply this patch: https://gist.github.com/marcinwasowicz/35071cea6abade632df8bc30f71fb1ab to send messages and rescinds to native device from web.
  2. Ensure that badge count stays consistent both in the background (notifs code modifies badge count) and in the foreground (JS modifies badge count)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Aug 28 2024, 3:12 AM
Herald added a subscriber: ashoat. · View Herald TranscriptAug 28 2024, 3:12 AM
marcin added a parent revision: D13189: JSI to update unread thick thread IDs in MMKV.Aug 28 2024, 3:13 AM
marcin edited the summary of this revision. (Show Details)Aug 28 2024, 3:15 AM
marcin edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B31320: Diff 43728.Aug 28 2024, 3:49 AM
marcin requested review of this revision.Aug 28 2024, 3:49 AM
tomek accepted this revision.Aug 29 2024, 6:27 AM
tomek added inline comments.
native/push/push-handler.react.js
831 ↗(On Diff #43728)

What does bound mean in this context?

This revision is now accepted and ready to land.Aug 29 2024, 6:27 AM
marcin added a child revision: D13210: Update badge count on web and desktop taking into account thick threads.Aug 29 2024, 1:50 PM
marcin added inline comments.Sep 2 2024, 8:10 AM
native/push/push-handler.react.js
831 ↗(On Diff #43728)

I was following the naming convention for other variables: boundUnreadCount and boundConnection.

marcin updated this revision to Diff 43838.Sep 2 2024, 9:05 AM

Readability rename

Harbormaster failed remote builds in B31393: Diff 43838!Sep 2 2024, 9:29 AM
marcin updated this revision to Diff 43866.Sep 3 2024, 7:32 AM

Rebase before landing

Harbormaster completed remote builds in B31420: Diff 43866.Sep 3 2024, 8:09 AM
Closed by commit rCOMMc60c0337be1f: Update badge count from JS on native taking into account thick threads (authored by Marcin Wąsowicz <marcinwasowicz@MacBook-Pro-Marcin.local>). · Explain WhySep 3 2024, 8:20 AM
This revision was automatically updated to reflect the committed changes.
Marcin Wąsowicz <marcinwasowicz@MacBook-Pro-Marcin.local> added a commit: rCOMMc60c0337be1f: Update badge count from JS on native taking into account thick threads.
ashoat added a comment.Sep 9 2024, 4:56 AM
  1. If we are connected to the tunnelbroker, we trust redux and update notifs storage (MMKV) with data from redux.
  2. If we are disconnected from the tunnelbroker, we trust notifs storage (MMKV) and fetch data from there.

Can you explain this approach in a bit more detail? Why do we trust Redux if (and only if?) we are connected to Tunnelbroker? And why do we trust notifs storage when we don't trust Redux?

marcin added a comment.Sep 9 2024, 6:17 AM
In D13190#374009, @ashoat wrote:
  1. If we are connected to the tunnelbroker, we trust redux and update notifs storage (MMKV) with data from redux.
  2. If we are disconnected from the tunnelbroker, we trust notifs storage (MMKV) and fetch data from there.

Can you explain this approach in a bit more detail? Why do we trust Redux if (and only if?) we are connected to Tunnelbroker? And why do we trust notifs storage when we don't trust Redux?

This the same logic that we agreed on during one of our 1:1 in February while discussing unread count for multiple keyservers.

If we are connected to Tunnelbroker then redux will have the latest updates on unread counts which should be more up to date than updates from notifs. If we are not connected to Tunnelbroker then notifs should be more up to date.

ashoat added a comment.Sep 9 2024, 1:07 PM

Okay, thanks for explaining!

Revision Contents
Changeset List

PathSize
lib/
selectors/
14 lines
native/
push/
42 lines

Diff 43866

View Options

lib/selectors/thread-selectors.js

Loading...
View Options

native/push/push-handler.react.js

Loading...