issue: ENG-8974
I went through all places where createPendingThread is used and checked what needs to be done for them. Some places still need to be updated, but they are related to useExistingThreadInfoFinder, which is a different task.
Details
Details
- Tested that ComposeThreadButton creates a thick thread now. It's the button used on iOS for creating a new chat from the chat tab
- composeThread in ChatThreadList is the same as ComposeThreadButton, but for Android instead of iOS. Assuming it works since iOS works
- Checked that Top/bar which uses useThreadInfoForPossiblyPendingThread correctly shows the name of the user the ucrrent user is not friends with. Checked that it correctly shows the name of a chat the user is a member of
- createPendingPersonalThread is used in
- createPendingThreadItem used to create an item in the thread list, but only for personal chats with users the current user has not yet messaged ever. Checked that their names are shown correctly in those items.
- useUserProfileThreadInfo used to display profile info of users the user doesn't yet know. Thested that their name and friendship buttons are shown correctly
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- inka/thread_ops
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/shared/thread-utils.js | ||
|---|---|---|
| 1491–1493 | This makes thick sidebars be created in thick threads. Checked it works | |
| lib/shared/thread-utils.js | ||
|---|---|---|
| 588 | Should this use a flag? | |