[lib] Update existingThreadInfoFinder to handle thick threads
ClosedPublic
Actions

Authored by inka on Sep 9 2024, 3:08 AM.

Details

Reviewers

tomek
kamil

Commits

rCOMM937dd440cde6: [lib] Update existingThreadInfoFinder to handle thick threads

Summary

issue: ENG-8433
If a chat under GENESIS exists for the given list of users, we want to return it. Otherwise we want to check for DM chat for the given set of users.

Test Plan

Tested that is a chat under GENSIS exists, it is returned. Tested that otherwise, if a DM chat exists, it is returned. Tested that if neither exist, no chat is shown, and it is possible to create a chat (DM or under GENESIS, depening on usingOlmViaTunnelbrokerForDMs flag).

Diff Detail

Repository

rCOMM Comm

Branch

inka/thread_ops

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Sep 9 2024, 3:08 AM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 9 2024, 3:08 AM

inka added a parent revision: D13259: [lib] Fix sendnig create_sidebar to peers.Sep 9 2024, 3:09 AM

inka added inline comments.Sep 9 2024, 3:17 AM

lib/selectors/thread-selectors.js
456–457	We want to determine pending form for thick threads as well
lib/shared/thread-utils.js
1259	If I understand the intention behind the original code correctly, we want to use the thread id of the input thread, unless a thread is being created. If a thread is being created, we want to create a DM thread. Before that tough, we want to check if a thread with the same list of users doesn't already exist. Additionally, because we are not yet fully migrated from GENESIS threads ti DMs, we want to check if there is such chat under GENESIS.