Differential D13306

[lib] Fix read only in thread-types
ClosedPublic
Actions

Authored by inka on Sep 12 2024, 6:27 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 1, 3:38 PM

	Unknown Object (File)
	Tue, Apr 1, 2:27 PM

	Unknown Object (File)
	Tue, Apr 1, 6:09 AM

	Unknown Object (File)
	Mon, Mar 31, 8:07 AM

	Unknown Object (File)
	Thu, Mar 20, 8:12 AM

	Unknown Object (File)
	Mar 6 2025, 7:09 AM

	Unknown Object (File)
	Mar 5 2025, 10:40 PM

	Unknown Object (File)
	Mar 5 2025, 8:05 AM

View All 68 Files

Subscribers

None

Details

Reviewers

tomek
ashoat

Commits

rCOMM73571573414d: [lib] Fix read only in thread-types

Summary

When spreading we loose the read-only properties

Test Plan

flow

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Sep 12 2024, 6:27 AM

inka added a child revision: D13243: [lib] Add useNewThickThread.Sep 12 2024, 6:27 AM

inka mentioned this in D13243: [lib] Add useNewThickThread.Sep 12 2024, 6:33 AM

Harbormaster completed remote builds in B31561: Diff 44079.Sep 12 2024, 6:45 AM

inka requested review of this revision.Sep 12 2024, 6:45 AM

tomek accepted this revision.Sep 12 2024, 7:42 AM

This revision is now accepted and ready to land.Sep 12 2024, 7:42 AM

Closed by commit rCOMM73571573414d: [lib] Fix read only in thread-types (authored by inka). · Explain WhySep 12 2024, 8:04 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM73571573414d: [lib] Fix read only in thread-types.

Revision Contents
Changeset List

Path

Size

lib/

types/

thread-types.js

16 lines

Diff 44079

lib/types/thread-types.js

	// @flow			// @flow

	import type { StateSyncSpec } from './state-sync-spec.js';			import type { StateSyncSpec } from './state-sync-spec.js';
				import type {
				CurrentUserInfo,
				OldCurrentUserInfo,
				} from '../../types/user-types.js';
				import { currentUserInfoValidator } from '../../types/user-types.js';
				import { convertClientIDsToServerIDs } from '../../utils/conversion-utils.js';
				import { ashoatKeyserverID } from '../../utils/validation-utils.js';

	export const currentUserStateSyncSpec: StateSyncSpec<> = Object.freeze({			export const currentUserStateSyncSpec: StateSyncSpec<
				OldCurrentUserInfo \| CurrentUserInfo,
				> = Object.freeze({
	hashKey: 'currentUserInfo',			hashKey: 'currentUserInfo',
				convertClientToServerInfos(info: OldCurrentUserInfo \| CurrentUserInfo) {
				return convertClientIDsToServerIDs(
				ashoatKeyserverID,
				currentUserInfoValidator,
				info,
				);
				},
	});			});