Page MenuHomePhabricator

[lib] Update existingThreadInfoFinder to handle thick threads
ClosedPublic

Authored by inka on Sep 9 2024, 3:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 5:57 AM
Unknown Object (File)
Fri, Nov 1, 5:35 AM
Unknown Object (File)
Tue, Oct 22, 10:45 AM
Unknown Object (File)
Tue, Oct 22, 10:19 AM
Unknown Object (File)
Tue, Oct 22, 5:34 AM
Unknown Object (File)
Tue, Oct 22, 5:33 AM
Unknown Object (File)
Mon, Oct 14, 2:28 PM
Unknown Object (File)
Sep 29 2024, 2:16 AM
Subscribers

Details

Summary

issue: ENG-8433
If a chat under GENESIS exists for the given list of users, we want to return it. Otherwise we want to check for DM chat for the given set of users.

Test Plan

Tested that is a chat under GENSIS exists, it is returned. Tested that otherwise, if a DM chat exists, it is returned. Tested that if neither exist, no chat is shown, and it is possible to create a chat (DM or under GENESIS, depening on usingOlmViaTunnelbrokerForDMs flag).

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lib/selectors/thread-selectors.js
456–457 ↗(On Diff #43970)

We want to determine pending form for thick threads as well

lib/shared/thread-utils.js
1259 ↗(On Diff #43970)

If I understand the intention behind the original code correctly, we want to use the thread id of the input thread, unless a thread is being created.
If a thread is being created, we want to create a DM thread. Before that tough, we want to check if a thread with the same list of users doesn't already exist. Additionally, because we are not yet fully migrated from GENESIS threads ti DMs, we want to check if there is such chat under GENESIS.

inka requested review of this revision.Sep 9 2024, 3:36 AM
This revision is now accepted and ready to land.Sep 11 2024, 2:27 AM